Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded Option map in PyMultiHostUrl.build #1643

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Remove unneeded Option map in PyMultiHostUrl.build #1643

merged 2 commits into from
Feb 24, 2025

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Feb 24, 2025

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 24, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1643 will not alter performance

Comparing linting-fix-url-host (f1bba2f) with main (68b678d)

Summary

✅ 157 untouched benchmarks

sydney-runkle
sydney-runkle approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to the new clippy version :)

@davidhewitt davidhewitt merged commit 248bd8b into main Feb 24, 2025
30 of 31 checks passed
@davidhewitt davidhewitt deleted the linting-fix-url-host branch February 24, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Viicos @sydney-runkle @davidhewitt