Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pydantic-core to v2.29.0 #11402

Merged

Conversation

mikeedjones
Copy link
Contributor

@mikeedjones mikeedjones commented Feb 5, 2025

Change Summary

Related issue number

#11360

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Feb 5, 2025
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Hh]ashable

Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #11402 will improve performances by 17.27%

Comparing mikeedjones:add-set_item_not_hashable-doc (0a1971f) with main (398b4bb)

Summary

⚡ 15 improvements
✅ 31 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_fastapi_startup_perf 148.1 ms 140.3 ms +5.6%
test_fastapi_startup_perf 20.9 ms 19.9 ms +5.09%
test_complex_model_schema_generation 1.5 ms 1.4 ms +5.93%
test_construct_dataclass_schema 1.4 ms 1.2 ms +17.27%
test_lots_of_models_with_lots_of_fields 2.3 s 2 s +16.79%
test_nested_model_schema_generation 863.7 µs 803.8 µs +7.45%
test_recursive_model_schema_generation 844.9 µs 793 µs +6.56%
test_simple_model_schema_generation 612.7 µs 574.9 µs +6.58%
test_simple_model_schema_lots_of_fields_generation 22.7 ms 21.6 ms +5.27%
test_tagged_union_with_callable_discriminator_schema_generation 1,119.5 µs 995.8 µs +12.43%
test_tagged_union_with_str_discriminator_schema_generation 1,161.8 µs 998.5 µs +16.36%
test_deeply_nested_recursive_model_schema_generation 1.1 ms 1 ms +5.7%
test_generic_recursive_model_schema_generation 736.6 µs 695.3 µs +5.93%
test_recursive_discriminated_union_with_base_model 1.4 ms 1.3 ms +7.9%
test_simple_recursive_model_schema_generation 617.7 µs 578.1 µs +6.84%

@mikeedjones mikeedjones marked this pull request as ready for review February 6, 2025 18:04
@mikeedjones
Copy link
Contributor Author

mikeedjones commented Feb 6, 2025

please review - CI tests failing whilst waiting for next pydantic-core release which adds new error code to ErroType.

@mikeedjones mikeedjones changed the title Add docs for set_item_not_hashable Add docs for new error type set_item_not_hashable from pydantic/pydantic-core#1619 Feb 6, 2025
@Viicos Viicos changed the title Add docs for new error type set_item_not_hashable from pydantic/pydantic-core#1619 Add new set_item_not_hashable error when trying to validate unhashable values against a set Feb 7, 2025
@Viicos Viicos changed the title Add new set_item_not_hashable error when trying to validate unhashable values against a set Add a new set_item_not_hashable error when trying to validate unhashable values against a set Feb 7, 2025
@Viicos Viicos added awaiting author revision awaiting changes from the PR author and removed ready for review labels Feb 7, 2025
sydney-runkle and others added 2 commits February 7, 2025 12:51
Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Uu]nhashable

@sydney-runkle sydney-runkle changed the title Add a new set_item_not_hashable error when trying to validate unhashable values against a set Bump pydantic-core to v2.29.0 Feb 7, 2025
@sydney-runkle sydney-runkle added relnotes-performance Used for performance improvements. relnotes-packaging Used for dependency changes. and removed awaiting author revision awaiting changes from the PR author relnotes-fix Used for bugfixes. relnotes-packaging Used for dependency changes. labels Feb 7, 2025
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs update!

@sydney-runkle sydney-runkle enabled auto-merge (squash) February 7, 2025 18:26
@sydney-runkle sydney-runkle merged commit 144e426 into pydantic:main Feb 7, 2025
53 checks passed
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-performance Used for performance improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants