Ensure group names are preserved on update.

pydata · Aug 2, 2024 · 78067f6 · 78067f6
1 parent c7cb9f7
commit 78067f6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/xarray/core/datatree.py b/xarray/core/datatree.py
@@ -770,7 +770,7 @@ def _replace_node(
         if data is not _default:
             self._set_node_data(ds)
 
-        self._children = children
+        self.children = children
 
     def copy(
         self: DataTree,

diff --git a/xarray/tests/test_datatree.py b/xarray/tests/test_datatree.py
@@ -245,6 +245,7 @@ def test_update(self):
         dt.update({"foo": xr.DataArray(0), "a": DataTree()})
         expected = DataTree.from_dict({"/": xr.Dataset({"foo": 0}), "a": None})
         assert_equal(dt, expected)
+        assert dt.groups == ("/", "/a")
 
     def test_update_new_named_dataarray(self):
         da = xr.DataArray(name="temp", data=[0, 50])