use ruff.flake8-tidy-imports to enforce absolute imports

pydata · Jan 29, 2024 · 8579bef · 8579bef
1 parent e22b475
commit 8579bef
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -10,12 +10,6 @@ repos:
       - id: check-yaml
       - id: debug-statements
       - id: mixed-line-ending
-  - repo: https://github.com/MarcoGorelli/absolufy-imports
-    rev: v0.3.1
-    hooks:
-      - id: absolufy-imports
-        name: absolufy-imports
-        files: ^xarray/
   - repo: https://github.com/astral-sh/ruff-pre-commit
     # Ruff version.
     rev: 'v0.1.9'

diff --git a/pyproject.toml b/pyproject.toml
@@ -242,6 +242,9 @@ extend-exclude = [
   "doc",
   "_typed_ops.pyi",
 ]
+extend-safe-fixes = [
+  "TID252", # absolute imports
+]
 target-version = "py39"
 
 [tool.ruff.lint]
@@ -257,13 +260,18 @@ select = [
   "F", # Pyflakes
   "E", # Pycodestyle
   "W",
+  "TID", # flake8-tidy-imports (absolute imports)
   "I", # isort
   "UP", # Pyupgrade
 ]
 
 [tool.ruff.lint.isort]
 known-first-party = ["xarray"]
 
+[tool.ruff.lint.flake8-tidy-imports]
+# Disallow all relative imports.
+ban-relative-imports = "all"
+
 [tool.pytest.ini_options]
 addopts = ["--strict-config", "--strict-markers"]
 filterwarnings = [