Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ruff.flake8-tidy-imports to enforce absolute imports #8680

Merged
merged 3 commits into from
Jan 30, 2024
Merged

use ruff.flake8-tidy-imports to enforce absolute imports #8680

merged 3 commits into from
Jan 30, 2024

Conversation

mathause
Copy link
Collaborator

@mathause mathause commented Jan 29, 2024 •
edited
Loading

use ruff.flake8-tidy-imports to enforce absolute imports

@mathause mathause force-pushed the ruff.flake8-tidy-imports branch from 0172761 to 3b438ce Compare January 29, 2024 15:40
@mathause
Copy link
Collaborator Author

Slightly less nice configuration wise (as I found no way to select files per-rule (only to exclude them))

max-sixty
max-sixty approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

andersy005
andersy005 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ thank you for this addition

@andersy005 andersy005 merged commit 208969b into pydata:main Jan 30, 2024
29 checks passed
@mathause mathause deleted the ruff.flake8-tidy-imports branch January 30, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

@andersy005 andersy005 andersy005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathause @max-sixty @andersy005