-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable numbagg
in calculation of quantiles
#8684
Conversation
This looks good! We should add this fixture to some quantile tests so we're testing with and without numbagg: xarray/xarray/tests/conftest.py Line 17 in 4b5c87b
Here's an example of it being used: xarray/xarray/tests/test_rolling.py Line 325 in 4b5c87b
|
Looks like some of the tests are failing:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@maawoo have been out for a few days but left one comment which I think will fix the tests (though it may need refining slightly). If you're up for it, could you add a whatsnew? Then we can merge, thanks! |
Thanks @maawoo |
Excellent work @maawoo ! Thank you! |
* main: Enable `numbagg` in calculation of quantiles (pydata#8684) Add lru_cache to named_array.utils.module_available and core.utils.module_available (pydata#8717)
skipna=True
is very slow #7377whats-new.rst
Just saw your message in the related issue @max-sixty. This is what I came up with earlier. I also did a quick test, comparing the calculation with and without using numbagg for a dummy 3D DataArray. I was only wondering if the default usage of numbagg (given that it's available and
method='linear'
) should be noted somewhere in the docstrings and/or the docs in general.