Fixes for pytest-8.0.0 compatibility #8686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove two incorrect `pytest.warns()` assertions to fix test failures with pytest-8.0.0. Prior to this version, an exception raised would cause `pytest.warns()` to be ignored. This way fixed in 8.0.0, and now warnings must actually be emitted prior to the exception. In `test_drop_index_labels()`, the exception is raised at the very beginning of the function, prior to the deprecation warning. In `test_rename_multiindex()`, the warning is not emitted at all (it is not applicable to the call in question).
Clear the warnings recorded during the `pytest.warns()` use in `test_groupby_dims_property`, to fix test failures with pytest-8.0.0. Prior to this version, `pytest.warns()` invocation used to capture all warnings. Now it only captures the warnings that match the arguments, and the remaining warnings are re-emitted and therefore caught by `recwarn` fixture. To provide compatibility with both versions of pytest, clear the recorded warnings immediately after `pytest.warns()`. Fixes pydata#8681
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
This reverts commit b0b5b2f. The tests should be fixed now.
|
Great first PR. Thanks @mgorny ! |
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes for compatibility with pytest 8.0.0:
pytest.warns()insidepytest.raises()where no warnings are actually raised.pytest.warns()invocation where the function expected all warnings to be captured.Explained in detail in commit messages.
whats-new.rstapi.rst