-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] pivot_longer_spec
#1362
[ENH] pivot_longer_spec
#1362
Conversation
🚀 Deployed on https://deploy-preview-1362--pyjanitor.netlify.app |
Ok, I just had a chance to look through the PR. Super high quality work! There was one file that was a tad too long where the implementation happened; I'm going to trust that it works fine. Otherwise, thank you for keeping the code test coverage high, @samukweku! |
I am going to approve. Please do the honors of merging! |
@ericmjl thanks for the feedback... I have to figure out how to break up such PRs into small chunks |
PR Description
Please describe the changes proposed in the pull request:
sort_by_appearance
is Truepivot_longer_spec
, which allows unpivoting by hand - this allows more granular control on how the final dataframe should look in long form.Performance test for lots of columns (YMMV):
This PR resolves #1361 .
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.md
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.