-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samukweku/refactor expand grid #1383
Conversation
🚀 Deployed on https://deploy-preview-1383--pyjanitor.netlify.app |
0274f67
to
8978a26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, @samukweku! Thank you for the creative work!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1383 +/- ##
==========================================
- Coverage 94.48% 89.76% -4.72%
==========================================
Files 80 87 +7
Lines 4367 5392 +1025
==========================================
+ Hits 4126 4840 +714
- Misses 241 552 +311 |
PR Description
Please describe the changes proposed in the pull request:
cartesian_product
function, as a saner alternative toexpand_grid
expand
method, similar to tidyr'sexpand
functioncomplete
based onexpand
methodshould also resolve this discussion here
performance YMMV (compared to pd.merge) :
This PR resolves #1293 .