Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samukweku/pivot longer simple #1400

Closed
wants to merge 11 commits into from
Closed

Conversation

samukweku
Copy link
Collaborator

PR Description

Please describe the changes proposed in the pull request:

  • all forms of pivot_longer handled by two major functions reshape_by_spec and reshape_by_spec_others
  • at its core, any pivot_longer function has to create a spec and pass to one of the two functions above.
  • add lots of comments on the implementation logic (for future me or others)
  • deprecate dropna - no perf difference if user does it, and is not needed within pivot_longer, plus we avoid the complexity of determing which NA rows to drop

This PR improves pivot_longer.

Please tag maintainers to review.

@samukweku samukweku self-assigned this Sep 12, 2024
@samukweku samukweku marked this pull request as draft September 12, 2024 07:14
@ericmjl
Copy link
Member

ericmjl commented Sep 12, 2024

@samukweku samukweku closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants