Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logic for others len in pivot_longer_spec #1406

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

samukweku
Copy link
Collaborator

@samukweku samukweku commented Sep 23, 2024

PR Description

Please describe the changes proposed in the pull request:

  • fix if statement that fails in pivot_longer_spec due to an empty list

This PR resolves #1405 .

Please tag maintainers to review.

@samukweku samukweku self-assigned this Sep 23, 2024
@samukweku samukweku linked an issue Sep 23, 2024 that may be closed by this pull request
@ericmjl
Copy link
Member

ericmjl commented Sep 23, 2024

Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericmjl
Copy link
Member

ericmjl commented Sep 23, 2024

@samukweku I'm going to merge. Please do the honors of cutting the new release!

@ericmjl ericmjl merged commit c04dcca into dev Sep 23, 2024
4 checks passed
samukweku added a commit that referenced this pull request Sep 29, 2024
Co-authored-by: samuel.oranyeli <samuel.oranyeli@grow.inc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] polars' pivot_longer_spec empty list
2 participants