Ruben new benchmarks #228
Ruben new benchmarks #228
Conversation
Good observation. I just saw in the [documentation)(https://pymanga.github.io/pyMANGA/project_dox__MangaProject__tree_dynamics__tree_growth_and_death__SimpleKiwi__SimpleKiwi.html) that there's no output available. That needs to be fixed (Issue #225 ). |
There was a problem hiding this comment.
Looks good for the start :)
I'm not sure if we shoud first restructure the ModuleBenchmarks folder before you proceed. Issue #222 contains suggestions for the new structure. @jvollhueter what do you think?
...oduleBenchmarks/BelowgroundCompetition/FixedSalinity_SimpleKiwi/FixedSalinity_SimpleKiwi.xml
Outdated
Show resolved
Hide resolved
...leBenchmarks/BelowgroundCompetition/FixedSalinity_SimpleKiwi/FixedSalinity_CI_SimpleKiwi.xml
Outdated
Show resolved
Hide resolved
...Salinity_SimpleKiwi/ReferenceFiles/FixedSalinity_CI_SimpleKiwi/Population_t_0002000000.0.csv
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Please apply the same changes regarding outputs and naming here
...ks/ModuleBenchmarks/BelowgroundCompetition/NetworkOGSLargeScale3D/NetworkOGSLargeScale3D.xml
Outdated
Show resolved
Hide resolved
…nto ruben_benchmarks
New benchmarks: FixedSalinity_SimpleKiwi, OGSLargeScale3D_SimpleKiwi, & NetworkOGSLargeScale3D.
Reference files need revision.
SimpleKiwi: Output for growth, ag_resources, bg_resources, & salinity is not available (NaN) in SimpleKiwi. Not sure if it's better to remove these entries completely for SimpleKiwi or if this is an error.