-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profile: add archived projects section #17571
profile: add archived projects section #17571
Conversation
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
{% if projects %} | ||
{% if project_count %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dug through this, and realized what was bothering me.
After this change, we confirm that there's actual projects, but the way the HTML is structured we end up with two package-list
entries, and nothing differentiates them. Could we/should we combine the logic so that there's one instance of a package-list
or at least provide some context to the div class that these are active
vs archived
? Or is that overthinking it for classes that don't have any CSS specific to them right now? (Ignore for a second that the CSS for package-list
was removed a long time ago.)
This is not a blocker, but I wanted to note it in case someone thinks it's important for later.
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Head branch was pushed to by a user without write access
…ofile Signed-off-by: William Woodruff <william@trailofbits.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last two comments (hopefully)!
Co-authored-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
…ofile Signed-off-by: William Woodruff <william@trailofbits.com>
Head branch was pushed to by a user without write access
Keep in mind: profile pages are cached for a day, so changes may not be immediately visible if the pages are not cached. |
This splits the project list in a user's public profile into two groups: "active" and "archived". Both are rendered as before, but archived projects are additionally given their own header (linked to a new help section) and each project is given a little "archived" badge that's identical to the badge elsewhere.
Example render:
CC @miketheman for feedback 🙂
Closes #17550.