Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct handling of fat3 macOS wheels and eggs. #17572

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

freakboy3742
Copy link
Contributor

Fixes #17566.

Warehouse currently accepts wheels of type fat32; this tag doesn't exist, and appears to be a typo of fat3. There are no examples of fat32 wheels in the Warehouse database (as Python tooling has never produced them, and pip would never request them).

It also labels eggs as "Source" (see https://pypi.org/project/pillow/2.5.0/#files for an example).

This PR:

  • Corrects the fat3 wheel tag
  • Adds architecture descriptors for the macOS combined architectures other than universal2
  • Ensures eggs are described as such
  • Adds tests for all of the above.

These changes are almost entirely anachronistic... but they are part of the spec, and the discrepancy (discovered during writing pypa/packaging.python.org#1804) was just itching me :-)

@freakboy3742 freakboy3742 requested a review from a team as a code owner February 7, 2025 04:20
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@di di merged commit 5c75fae into pypi:main Feb 7, 2025
20 checks passed
@freakboy3742 freakboy3742 deleted the fat-tag-fix branch February 8, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accepted macOS tags don't match canonical list.
2 participants