feat: add indicative price #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danimhr
reviewed
Feb 21, 2025
auction-server/Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "auction-server" | |||
| version = "0.18.1" | |||
| version = "0.18.2" | |||
There was a problem hiding this comment.
Use 0.19 as api is changed
| @@ -401,18 +402,27 @@ impl Service<ChainTypeSvm> { | |||
| bids.sort_by(|a, b| a.amount.cmp(&b.amount)); | |||
| } | |||
| } | |||
|
|
|||
| let indicative_price_request = | |||
There was a problem hiding this comment.
isn't it better to make the user_wallet_address optional in the QuoteCreate entity?
I think it we do so, some checks will be removed in this function :-?
|
I think you should update the swap UI we created for test to fix the Vercel error |
danimhr
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables ER to provide indicative prices when the
user_wallet_addressis not specified. It does this in a somewhat hacky way, reusing theget_quoteapi for ease.TODO: