feat: return a quote when not enough funds #418
+304
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
guibescos
commented
Mar 6, 2025
•
guibescos
commented
- in auction service, we let through transactions that fail with the user insufficient funds error
- in opportunity service, we check if the user has enough funds and set tx in the response to none if they don't
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
anihamde
reviewed
Mar 6, 2025
| == InstructionError::Custom(ErrorCode::InsufficientUserFunds.into()) | ||
| { | ||
| // This path only works as long as none of the other accepted programs use this error number, which is currently true since express relay is the only program in the whitelist that uses anchor error codes | ||
| // TODO: Also check the instruction index here so we are sure it's coming from the swap instruction |
There was a problem hiding this comment.
wouldn't this TODO resolve the above comment? since ER doesn't make any CPIs to anything except system & token program?
| Some(_) => ( | ||
| let user_has_enough_balance = | ||
| if let Some(user_wallet_address) = input.quote_create.user_wallet_address { | ||
| self.check_user_token_balance(CheckUserTokenBalanceInput { |
There was a problem hiding this comment.
are we checking here to prevent sybiling? why do we need to make an RPC call every time a quote is requested? couldn't we just avoid this check and use the error code itself?
There was a problem hiding this comment.
it seems we could handle this in verification.rs and just return a third option to allow the bid to remain with a flag that this failed due to UserInsufficientFunds. then we don't have to recheck the token balance on chain?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.