Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-129061: Fix FORCE_COLOR and NO_COLOR when empty strings #129140

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 21, 2025

First refactor the tests into subtests, which makes it easier compare the env var inputs and expected outputs.

@hugovk hugovk force-pushed the 3.14-empty-force-color-no-color branch from b67ac03 to c7b5419 Compare January 21, 2025 21:48
@hugovk hugovk added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jan 21, 2025
@hugovk hugovk added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jan 22, 2025
@bedevere-bot

This comment was marked as resolved.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 22, 2025
@hugovk

This comment was marked as resolved.

@bedevere-bot

This comment was marked as resolved.

@hugovk

This comment was marked as resolved.

@bedevere-bot

This comment was marked as resolved.

@hugovk

This comment was marked as resolved.

@bedevere-bot

This comment was marked as resolved.

@hugovk

This comment was marked as resolved.

@bedevere-bot

This comment was marked as resolved.

@hugovk

This comment was marked as resolved.

@bedevere-bot

This comment was marked as resolved.

@hugovk

This comment was marked as resolved.

@bedevere-bot

This comment was marked as resolved.

@hugovk hugovk added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 22, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hugovk for commit ec36e22 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 22, 2025
@hugovk
Copy link
Member Author

hugovk commented Jan 23, 2025

Like #129137 (comment), test_external_inspection failed on Fedora and RHEL8 buildbots and is unrelated.

@hugovk hugovk marked this pull request as ready for review January 23, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants