Missing args callable #18990
Open
Missing args callable #18990
+78
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
Delete unrelated changes
for more information, see https://pre-commit.ci
Changed wrong files This reverts commit c4d3d0a.
Accidentally deleted the wrong changes This reverts commit 17ebfea.
for more information, see https://pre-commit.ci
accidentally committed local container files with changes
Accidentally included local container files in commit
cleaned up extra space
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
commit 91703e53b3e71b68faf512d310c72a16f0c1f185 resolves Issue #18994 |
This comment has been minimized.
This comment has been minimized.
|
@sterliakov ready for your review, when you have time. Thanks again for assisting with the internal error issue. |
sterliakov
suggested changes
May 1, 2025
| if name is not None and kind in (ARG_NAMED, ARG_POS): | ||
| if name not in arg_names_set: | ||
| if target_name == "misc": | ||
| continue # Skip error for miscellaneous/unknown classes |
There was a problem hiding this comment.
Many questions here... First, why is this code block preceding a docstring?
Second, there's no special-cased "misc" typing construct, this simply shouldn't exist. But fortunately this whole block starting from is_constructor_call = ... line is... doing nothing? Is this some kind of merge artifact? I don't see any use of these newly declared variables.
| @@ -59,3 +59,4 @@ class dict(Mapping[KT, VT]): | |||
| @overload | |||
| def get(self, k: KT, default: Union[KT, T]) -> Union[VT, T]: pass | |||
| def __len__(self) -> int: ... | |||
| import _typeshed | |||
There was a problem hiding this comment.
Let's move this to the very top (even though that may affect line numbers in 1-2 existing tests, that's simple enough)
test-data/unit/check-functions.test
Outdated
| def f3(x: Any): | ||
| return g(*x) | ||
|
|
||
| from typing import Optional |
There was a problem hiding this comment.
Does it need to be separated and not at the top? Why?
|
But the primer results look amazing - please keep going, let's get this working! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: prefect (https://github.com/PrefectHQ/prefect)
+ src/prefect/_internal/pydantic/v2_validated_func.py:50: error: Argument after ** must be a mapping, not "Union[type[Any], dict[str, Any], None]" [arg-type]
pandas (https://github.com/pandas-dev/pandas)
+ pandas/io/excel/_xlsxwriter.py:259: error: Expected iterable as variadic argument [misc]
antidote (https://github.com/Finistere/antidote)
+ src/antidote/core/_inject.py:348: error: Expected iterable as variadic argument [misc]
+ src/antidote/core/_inject.py:348: error: Argument after ** must be a mapping, not "dict[str, Any] | None" [arg-type]
xarray (https://github.com/pydata/xarray)
+ xarray/core/common.py: note: In member "squeeze" of class "DataWithCoords":
+ xarray/core/common.py:460: error: Keywords must be strings [misc]
+ xarray/core/dataset.py: note: In member "_stack_once" of class "Dataset":
+ xarray/core/dataset.py:5085: error: Keywords must be strings [misc]
pandera (https://github.com/pandera-dev/pandera)
+ tests/pandas/test_extensions.py:57: error: Argument after ** must be a mapping, not "object" [arg-type]
+ tests/pandas/test_extensions.py:99: error: Argument after ** must be a mapping, not "object" [arg-type]
openlibrary (https://github.com/internetarchive/openlibrary)
+ openlibrary/core/imports.py: note: In member "add_items" of class "Batch":
+ openlibrary/core/imports.py:131: error: Argument after ** must be a mapping, not "str | dict[Any, Any]" [arg-type]
jax (https://github.com/google/jax)
+ jax/_src/numpy/einsum.py:566: error: Argument after ** must be a mapping, not "NamedSharding | None" [arg-type]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18783
Updated suggested code from prototype and modified check_call_expr_with_callee_type so that all required named or positional arguments are supplied during constructor calls. Tests were also written to verify that missing arguments raise type-checking errors.