Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packaging to docker #2389

Closed
wants to merge 2 commits into from
Closed

Add packaging to docker #2389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f54f041
Add packaging to flash-attn dependency
xuzhao9 Jul 19, 2024
1f4f5fc
Add packaging as the docker dependency
xuzhao9 Jul 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/build-torchbench-nightly-docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
TORCHBENCH_BRANCH=${TORCHBENCH_BRANCH:-main}

docker build . -f torchbench-nightly.dockerfile -t ghcr.io/pytorch/torchbench:latest \
DOCKER_BUILDKIT=0 docker build . --no-cache -f torchbench-nightly.dockerfile -t ghcr.io/pytorch/torchbench:latest \
--build-arg TORCHBENCH_BRANCH=${TORCHBENCH_BRANCH}
1 change: 1 addition & 0 deletions userbenchmark/triton/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
packaging
flash-attn
3 changes: 2 additions & 1 deletion utils/cuda_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,8 @@ def install_torch_build_deps(cuda_version: str):


def install_torchbench_deps():
cmd = ["pip", "install", "unittest-xml-reporting", "boto3"]
# tritonbench flash_attn depends on packaging to build
cmd = ["pip", "install", "unittest-xml-reporting", "boto3", "packaging"]
subprocess.check_call(cmd)


Expand Down
Loading