Update torchbench pin on PyTorch CI #2584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huydhn
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
huydhn
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
huydhn
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
huydhn
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
huydhn
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
huydhn
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
huydhn
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
huydhn
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
huydhn
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
huydhn
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
huydhn
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
huydhn
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Feb 1, 2025
I'm adding sam2 to TorchBench pytorch/benchmark#2566, so, as part of that, I'm updating PyTorch CI to use latest TorchBench commit. The corresponding change from TorchBench is pytorch/benchmark#2584 The main thing to call out that the newer transformers added by pytorch/benchmark#2488 is regressing several models. This needs to be investigated further, and I pin the version to unblock this change. * `hf_Roberta_base` a new model added by pytorch/benchmark#2279, not sure why it fails accuracy on A10G, but it works fine on A100 * `speech_transformer` failures are pre-existing trunk failures, i.e. https://github.com/pytorch/pytorch/actions/runs/13040114684/job/36380989702#step:22:2408 Pull Request resolved: #145455 Approved by: https://github.com/kit1980
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
Summary: I'm adding sam2 to TorchBench #2566, so, as part of that, I'm updating PyTorch CI to use latest TorchBench commit. The corresponding change from TorchBench is #2584 The main thing to call out that the newer transformers added by #2488 is regressing several models. This needs to be investigated further, and I pin the version to unblock this change. * `hf_Roberta_base` a new model added by #2279, not sure why it fails accuracy on A10G, but it works fine on A100 * `speech_transformer` failures are pre-existing trunk failures, i.e. https://github.com/pytorch/pytorch/actions/runs/13040114684/job/36380989702#step:22:2408 X-link: pytorch/pytorch#145455 Approved by: https://github.com/kit1980 Reviewed By: ZainRizvi Differential Revision: D69056903 fbshipit-source-id: 6b98c246b9dc8811257ec46d4821ba6ee3363dfe
mori360
pushed a commit
to mori360/pytorch
that referenced
this pull request
Feb 6, 2025
I'm adding sam2 to TorchBench pytorch/benchmark#2566, so, as part of that, I'm updating PyTorch CI to use latest TorchBench commit. The corresponding change from TorchBench is pytorch/benchmark#2584 The main thing to call out that the newer transformers added by pytorch/benchmark#2488 is regressing several models. This needs to be investigated further, and I pin the version to unblock this change. * `hf_Roberta_base` a new model added by pytorch/benchmark#2279, not sure why it fails accuracy on A10G, but it works fine on A100 * `speech_transformer` failures are pre-existing trunk failures, i.e. https://github.com/pytorch/pytorch/actions/runs/13040114684/job/36380989702#step:22:2408 Pull Request resolved: pytorch#145455 Approved by: https://github.com/kit1980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding sam2 to TorchBench #2566, so, as part of that, I'm updating PyTorch CI to use latest TorchBench commit.
This goes together with pytorch/pytorch#145455. The list of fixes includes:
decoder_start_token_idto HFGenerationConfig. This was Introduced by transformers 4.41.0 transformers 4.41.0 breaks generate() for T5 huggingface/transformers#30892sam_faston A10G as it seems working correctly now