Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #991: Fixed mock script and added testcases for namespace creation #1114

Merged
merged 1 commit into from
Jan 2, 2022
Merged

Fixes #991: Fixed mock script and added testcases for namespace creation #1114

merged 1 commit into from
Jan 2, 2022

Conversation

andy-maier
Copy link
Contributor

@andy-maier andy-maier commented Dec 21, 2021 •
edited
Loading

For details, see commit message.

TODO:

DISCUSSION:

@andy-maier andy-maier self-assigned this Dec 21, 2021
@andy-maier andy-maier added this to the 1.0.0 milestone Dec 21, 2021
@andy-maier andy-maier force-pushed the andy/fix-namespace-creation branch 3 times, most recently from fdaf557 to 30e3ee9 Compare December 22, 2021 06:10
@andy-maier andy-maier changed the title [WIP] Added testcases for namespace creation Fixes #991: Fixed mock script and added testcases for namespace creation Dec 22, 2021
@andy-maier andy-maier linked an issue Dec 22, 2021 that may be closed by this pull request
Cannot set the default namespace to "interop" #991
Closed
@andy-maier andy-maier mentioned this pull request Dec 22, 2021
Closed
@coveralls
Copy link

coveralls commented Dec 22, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 92.907% when pulling 28c56ca on andy/fix-namespace-creation into 3a9493f on master.

@andy-maier andy-maier force-pushed the andy/fix-namespace-creation branch from 30e3ee9 to 8578263 Compare December 22, 2021 09:09
@andy-maier andy-maier mentioned this pull request Dec 22, 2021
Closed
@andy-maier andy-maier force-pushed the andy/fix-namespace-creation branch 2 times, most recently from 624b09d to 4ef4c77 Compare December 22, 2021 12:16
@andy-maier andy-maier mentioned this pull request Dec 23, 2021
Merged
@andy-maier andy-maier force-pushed the andy/fix-namespace-creation branch from 4ef4c77 to 0f9e60f Compare December 23, 2021 07:25
@andy-maier andy-maier force-pushed the andy/fix-namespace-creation branch 2 times, most recently from 02899c7 to 7bcf7a5 Compare December 23, 2021 07:46
KSchopmeyer
KSchopmeyer reviewed Dec 27, 2021
View reviewed changes
Copy link
Contributor

@KSchopmeyer KSchopmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. My comments are about packaging some of this into pywbemcli, etc. since we are repeating the same code to setup interop in multiple scripts.

@andy-maier andy-maier force-pushed the andy/fix-namespace-creation branch from 7bcf7a5 to bccfe1e Compare December 31, 2021 07:12
@andy-maier
Copy link
Contributor Author

We discussed whether this solution is good enough for solving issue #991 and concluded that that is the case.

@andy-maier
Fixes #991: Fixed mock scripts and added testcases for namespace crea…
28c56ca 
…tion

Details:

* Increased minimum version of pywbem to 1.4.0 (for now, pulling from
  branch).

* Fixed the simple_interop_mock_script.py mock script so that it now
  creates the Interop MOF always in the interop namespace. The user
  MOF continues to be created in the default namespace.

* Added a simple_foo_mock_script.py mock script that prepares an
  Interop namespace and then compiles user MOF into a namespace
  determined by the pragma namespace in the MOF.

* Added a new test file test_namespace_creation.py for various cases
  of namespace creation.

* For consistency, changed the simple_disablepull_mock_script.py
  mock script to also set up the Interop namespace in the same way,
  and to compile user MOF into root/cimv2, resulting in the same
  namespace setup as before the change.

* This allowed deletion of the no longer used
  simple_interop_mock_model.mof file, which was a somewhat simple minded
  approach to setting up an Interop namespace.

* Adjusted the expected error message for Interop namespace not found
  due to a corresponding change in pywbem 1.4.0.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
@andy-maier andy-maier force-pushed the andy/fix-namespace-creation branch from bccfe1e to 28c56ca Compare January 2, 2022 10:50
@andy-maier andy-maier merged commit 69d8578 into master Jan 2, 2022
@andy-maier andy-maier deleted the andy/fix-namespace-creation branch January 2, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSchopmeyer KSchopmeyer KSchopmeyer left review comments

Assignees

@andy-maier andy-maier

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Cannot set the default namespace to "interop"
3 participants
@andy-maier @coveralls @KSchopmeyer