-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Python 3.12; Fixed py34+ in docs #1360
Conversation
987a027
to
4e5b574
Compare
dev-requirements
Shouldn't this be >= rather than == |
This is a question: importlib-metadata package in minimum-constraints and dev-requirements The versions for this package have been moved from: importlib-metadata==0.23; python_version <= '3.7' to importlib-metadata==2.1.3; python_version <= '3.6' i.e the version changed from 0.23 to 2.1.3 and also the python-versions changed from 3.7 -> 3.6 and from 3.8 -> 3.7 Not sure why. |
flake8 package version change from 4.0.1 to 5.0.0 for python 10, Again question of why. flake8>=5.0.0; python_version >= '3.10' |
pycodestyle dev-requirements pycodestyle>=2.9.0; python_version >= '3.10' before it was 2.8.0 for python 3.10. Was this a simplification to have same version for 3.10 - 3.12 or was there a reason to change version from 2.8.0 to 2.9.0 for python 3.10 and python 3.11. |
dev-requirements importlib-metadata: Indeed, this was a mistake and should be |
On importlib-metadata versions: I think I took that from zhmcclient. When looking at the versions though, 2.1.3 is the last version supporting py35 and 4.8.3 is the last version supporting 3.6. So I think I got the python versions wrong and it should have been:
I don't recall why I increased the versions in the first place, but it probably was the desire to use the latest possible versions. Tox and nbconvert have increased their minimum versions of importlib-metadata way beyond the long used version 0.12, so it is definitely time to go up there. |
On flake8 change from 4.0.1 to 5.0.0 for python 3.10: Not sure - probably another copy from zhmcclient. The entire flake8 section looks the same. Probably the same for the pycodestyle changes. |
I changed the python version boundary for importlib-metadata to match what the required versions support:
|
4e5b574
to
25c8f85
Compare
25c8f85
to
6702e43
Compare
Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
6702e43
to
81015a5
Compare
Approved |
No description provided.