Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Python 3.12; Fixed py34+ in docs #1360

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

andy-maier
Copy link
Contributor

No description provided.

@andy-maier andy-maier self-assigned this Jan 29, 2024
@andy-maier andy-maier added this to the 1.3.0 milestone Jan 29, 2024
@andy-maier andy-maier force-pushed the andy/py312 branch 4 times, most recently from 987a027 to 4e5b574 Compare January 29, 2024 06:48
@coveralls
Copy link

coveralls commented Jan 29, 2024

Coverage Status

coverage: 92.609% (+0.01%) from 92.595%
when pulling 81015a5 on andy/py312
into 675cb32 on master.

@KSchopmeyer
Copy link
Contributor

dev-requirements

importlib-metadata==2.1.3,<5.0.0; python_version <= '3.6'
importlib-metadata==4.8.3; python_version >= '3.7'

Shouldn't this be >= rather than ==

@KSchopmeyer
Copy link
Contributor

This is a question:

importlib-metadata package in minimum-constraints and dev-requirements

The versions for this package have been moved from:

importlib-metadata==0.23; python_version <= '3.7'
importlib-metadata==4.8.3; python_version >= '3.8'

to

importlib-metadata==2.1.3; python_version <= '3.6'
importlib-metadata==4.8.3; python_version >= '3.7'

i.e the version changed from 0.23 to 2.1.3 and also the python-versions changed from 3.7 -> 3.6 and from 3.8 -> 3.7

Not sure why.

@KSchopmeyer
Copy link
Contributor

flake8 package version change from 4.0.1 to 5.0.0 for python 10, Again question of why.

flake8>=5.0.0; python_version >= '3.10'

@KSchopmeyer
Copy link
Contributor

pycodestyle dev-requirements

pycodestyle>=2.9.0; python_version >= '3.10'

before it was 2.8.0 for python 3.10.

Was this a simplification to have same version for 3.10 - 3.12 or was there a reason to change version from 2.8.0 to 2.9.0 for python 3.10 and python 3.11.

@andy-maier
Copy link
Contributor Author

dev-requirements importlib-metadata: Indeed, this was a mistake and should be >=

@andy-maier
Copy link
Contributor Author

On importlib-metadata versions: I think I took that from zhmcclient. When looking at the versions though, 2.1.3 is the last version supporting py35 and 4.8.3 is the last version supporting 3.6. So I think I got the python versions wrong and it should have been:

importlib-metadata==2.1.3; python_version <= '3.5'
importlib-metadata==4.8.3; python_version >= '3.6'

I don't recall why I increased the versions in the first place, but it probably was the desire to use the latest possible versions. Tox and nbconvert have increased their minimum versions of importlib-metadata way beyond the long used version 0.12, so it is definitely time to go up there.

@andy-maier
Copy link
Contributor Author

andy-maier commented Feb 27, 2024

On flake8 change from 4.0.1 to 5.0.0 for python 3.10: Not sure - probably another copy from zhmcclient. The entire flake8 section looks the same.

Probably the same for the pycodestyle changes.

@andy-maier
Copy link
Contributor Author

I changed the python version boundary for importlib-metadata to match what the required versions support:

importlib-metadata==2.1.3; python_version <= '3.5'
importlib-metadata==4.8.3; python_version >= '3.6'

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
@KSchopmeyer
Copy link
Contributor

Approved

@andy-maier andy-maier merged commit ca7a08b into master Mar 3, 2024
16 checks passed
@andy-maier andy-maier deleted the andy/py312 branch March 3, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants