Remove additional python 2.7 leftover. #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSchopmeyer
force-pushed
the
ks/#more-py27-removal
branch
from
68aaaac to
2d2a174
Compare
|
Karl, can you please rebase this PR on the latest master? That should solve the issues. DONE: ks |
KSchopmeyer
force-pushed
the
ks/#more-py27-removal
branch
from
2d2a174 to
b995dc5
Compare
Removes another couple of things involving python 2.7 1. Test that was specialized for python 2.7 on windows, Issue 1590 2. Reference to python 2.7 in pywbem_server 3. Remove tests/unit/pywbemcli/test_python_tell.py - This test was created to confirm that there were no issues between the tell() function on windows with python 2.7 and to verify that test_build_mockenv() works. With the removal of python 2.7 as a platform, this test is no longer necessary. 4. version doc that used python 2.7.11 as example in tools. Note that one test in test_pywbemcli_operations.py from the group that was disabled because of a windows issue is still marked disabled because that test fails. See issue #1440.
KSchopmeyer
force-pushed
the
ks/#more-py27-removal
branch
from
b995dc5 to
8d15d22
Compare
andy-maier
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes another couple of things involving python 2.7
Removing the py2.7 test code that bypassed tied to issue #1590 where we were skipping tests many pywbemcli_cimoperations.py tests on windows showed a potential problem in windows where pywbemcli may not be correctly making the decision to rebuild the cache when the cache md5 values do not match. See below.
E ---- Actual stdout:
E Mock environment for connection definition 'test_build_mockenv' has been loaded from cache.
E
E ---- Expected line (regexp):
E Mock environment .* will be rebuilt because the mock files have changed.
E ---- End
however this passes test in local windows tests. I disabled this one test and filed issue #1440 rather than block this whole change.