Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep unwanted files in separate folder #19842

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Conversation

glassez
Copy link
Member

@glassez glassez commented Oct 31, 2023

Revives the "Unwanted folder" feature that keep all the unchecked files in ".unwanted" subfolders.

Closes #13531.

@glassez glassez added the Core label Oct 31, 2023
@glassez glassez added this to the 5.0 milestone Oct 31, 2023
@glassez glassez requested a review from a team October 31, 2023 16:57
Copy link
Contributor

@thalieht thalieht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find any problems

@sjlebl
Copy link

sjlebl commented Nov 3, 2023

This was SUCH a great effort. MUCH MUCH appreciation to the coder. I've been using 4.2.5 since forever.

It launched wonderfully and I unchecked a few files in existing torrents and it created .unwanted as expected, I could still run and rename the files in .unwanted. I moved the download location several times and the .unwanted folder behaved correctly. I started several NEW torrents and the behavior with DO NOT DOWNLOAD and .unwanted was exactly as expected. THANK YOU SO MUCH.

@glassez glassez merged commit e216a9c into qbittorrent:master Nov 5, 2023
@glassez glassez deleted the unwanted branch November 5, 2023 09:00
@mzso
Copy link

mzso commented Nov 12, 2023

I can't say I can interpret the PR very so I'm gonna ask: Was configuration to disable/enable this implemented, or is it still to come?

Well, it be deployed as opt-in (off by default)?

@thalieht
Copy link
Contributor

Was configuration to disable/enable this implemented, or is it still to come?

#19926

@BattouSaeen
Copy link

This was SUCH a great effort. MUCH MUCH appreciation to the coder. I've been using 4.2.5 since forever.

It launched wonderfully and I unchecked a few files in existing torrents and it created .unwanted as expected, I could still run and rename the files in .unwanted. I moved the download location several times and the .unwanted folder behaved correctly. I started several NEW torrents and the behavior with DO NOT DOWNLOAD and .unwanted was exactly as expected. THANK YOU SO MUCH.

@sjlebl hey, did you directly update from 4.2.5 to (which version? Current now?)? Any problems?

@BattouSaeen
Copy link

BattouSaeen commented Dec 27, 2023

Hi @glassez could you kindly refresh how the options work now?
After installing 4.6.2, I saw layout options - Original, Create Subfolder and Don't create subfolder.

I assume Original is same as Create subfolder? Or are they different?

Either way, neither of these two settings did anything on downloading and completed torrents when I unchecked/checked a file.

Or has this meant to come in for 5.0?

@thalieht
Copy link
Contributor

After installing 4.6.2, I saw layout options - Original, Create Subfolder and Don't create subfolder.

Totally irrelevant options. (Don't) create sub folder is to make sure all files in the torrent are put/taken out of the torrent's root folder (some torrents have only just one file dumped in the save location). Original is don't touch the torrent's root folder (or lack of).

Or has this meant to come in for 5.0?

Yes.

@BattouSaeen
Copy link

@thalieht thanks for the clarification. If I may, I noticed that when I installed 4.6.2, a lot of old magnet links lost their titles in the downloads list and ended up with the gibberish numbers that are part of the magnet link; but when I reverted to 4.2.5, they returned. So I guess something is not being read in the newer versions because the data seems to be there when downgrading. If you have any thoughts on that please let me know; perhaps it's a bug that can be fixed for future builds or something can be done on my end, although I wouldn't know what to do about such old magnet link entries, they were probably part of some temporary files that got deleted ages ago and I'd hate to lose so many like that.

@thalieht
Copy link
Contributor

If I may, I noticed that when I installed 4.6.2, a lot of old magnet links lost their titles in the downloads list and ended up with the gibberish numbers that are part of the magnet link; but when I reverted to 4.2.5, they returned

I don't know. IIRC some info were moved from the .torrent file to the .fastresume file or the other way around since then... can't remember. Maybe if you would share such a .torrent+.fastresume pair someone who knows more could tell you what's up (not here, it will probably be forgotten).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I know .unwanted folder was meant to be gone, but what's new behaviour supposed to be?
5 participants