-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep unwanted files in separate folder #19842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't find any problems
This was SUCH a great effort. MUCH MUCH appreciation to the coder. I've been using 4.2.5 since forever. It launched wonderfully and I unchecked a few files in existing torrents and it created .unwanted as expected, I could still run and rename the files in .unwanted. I moved the download location several times and the .unwanted folder behaved correctly. I started several NEW torrents and the behavior with DO NOT DOWNLOAD and .unwanted was exactly as expected. THANK YOU SO MUCH. |
I can't say I can interpret the PR very so I'm gonna ask: Was configuration to disable/enable this implemented, or is it still to come? Well, it be deployed as opt-in (off by default)? |
|
@sjlebl hey, did you directly update from 4.2.5 to (which version? Current now?)? Any problems? |
Hi @glassez could you kindly refresh how the options work now? I assume Original is same as Create subfolder? Or are they different? Either way, neither of these two settings did anything on downloading and completed torrents when I unchecked/checked a file. Or has this meant to come in for 5.0? |
Totally irrelevant options.
Yes. |
@thalieht thanks for the clarification. If I may, I noticed that when I installed 4.6.2, a lot of old magnet links lost their titles in the downloads list and ended up with the gibberish numbers that are part of the magnet link; but when I reverted to 4.2.5, they returned. So I guess something is not being read in the newer versions because the data seems to be there when downgrading. If you have any thoughts on that please let me know; perhaps it's a bug that can be fixed for future builds or something can be done on my end, although I wouldn't know what to do about such old magnet link entries, they were probably part of some temporary files that got deleted ages ago and I'd hate to lose so many like that. |
I don't know. IIRC some info were moved from the .torrent file to the .fastresume file or the other way around since then... can't remember. Maybe if you would share such a .torrent+.fastresume pair someone who knows more could tell you what's up (not here, it will probably be forgotten). |
Revives the "Unwanted folder" feature that keep all the unchecked files in ".unwanted" subfolders.
Closes #13531.