Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Torrent files watcher internals #19924

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Improve Torrent files watcher internals #19924

merged 1 commit into from
Nov 13, 2023

Conversation

glassez
Copy link
Member

@glassez glassez commented Nov 11, 2023 •
edited
Loading

Fixes regression of #19650.

QObject::~QObject: Timers cannot be stopped from another thread

Supercedes #19741.

@glassez glassez added the Watched folders Watched folders related issues/changes label Nov 11, 2023
@glassez glassez added this to the 5.0 milestone Nov 11, 2023
@glassez glassez requested a review from a team November 11, 2023 07:36
@glassez glassez mentioned this pull request Nov 11, 2023
Closed
@glassez glassez merged commit 8cc8ffa into qbittorrent:master Nov 13, 2023
13 checks passed
@glassez glassez deleted the watcher branch November 13, 2023 11:27
@Chocobo1
Copy link
Member

@glassez
Should this be backported to v4.6.x?

@glassez
Copy link
Member Author

glassez commented Nov 16, 2023

@glassez Should this be backported to v4.6.x?

Maybe later.
It affects code that used to cause crashes under some conditions that are difficult for me to reproduce (e.g. building using musl instead of glibc), so I can't be sure that this patch has no regression. Nevertheless, it seems to work without problems under normal conditions.

@glassez glassez mentioned this pull request Nov 16, 2023
Merged
@glassez glassez modified the milestones: 5.0, 4.6.2 Nov 19, 2023
glassez added a commit to glassez/qBittorrent that referenced this pull request Nov 21, 2023
@glassez
Improve Torrent files watcher internals
a57b80c 
PR qbittorrent#19924.
@glassez glassez mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chocobo1 Chocobo1 Chocobo1 approved these changes

@thalieht thalieht thalieht approved these changes

Assignees
No one assigned
Labels
Watched folders Watched folders related issues/changes
Projects
None yet
Milestone
4.6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@glassez @Chocobo1 @thalieht