Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate lladser_ci with improved handling of ci Results #287

Open
ChrisKeefe opened this issue Aug 7, 2020 · 0 comments
Open

Reinstate lladser_ci with improved handling of ci Results #287

ChrisKeefe opened this issue Aug 7, 2020 · 0 comments
Assignees

Comments

@ChrisKeefe
Copy link
Collaborator

ChrisKeefe commented Aug 7, 2020

Improvement Description
lladser_ci was removed in #286 as an expedient bugfix, and should be reinstated (in q2-diversity-lib) with proper handling of its unique parameters.

@gregcaporaso suggested "maybe this should be a new top-level action in q2-diversity, probably with it’s own semantic type for the output (e.g., SampleData[AlphaDiversityConfidenceInterval])".

Creation of a new semantic type for CI metrics would allow us to prevent users from passing these results into inappropriate downstream methods, and may support how we handle #183.

@ChrisKeefe ChrisKeefe self-assigned this Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant