Fix new HN time format breaking Newest Items

qsantos · Oct 23, 2024 · cef5a5b · cef5a5b
1 parent 87d99e6
commit cef5a5b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# v1.28
+
+- Handle new time format in Hacker News that breaks Newest Items
+
 # v1.27
 
 - Immediately scroll to corresponding item when navigating newest items #54

diff --git a/main.js b/main.js
@@ -340,9 +340,10 @@ chrome.storage.sync.get((options) => {
         parts.push("<ul>");
         let lastDay = null;
         for (const [datetime, index] of datedIndexes) {
-            // for format provided by Hacker News is "2024-09-03T19:06:26.000000Z"
-            const [day, rest] = datetime.split("T");
-            const [time, fraction] = rest.split(".");
+            // for format provided by Hacker News is "2024-09-03T19:06:26 000000"
+            // slice should be slightly more robust to change than split
+            const day = datetime.slice(0, 10);
+            const time = datetime.slice(11, 19);
             if (day === lastDay) {
                 parts.push(
                     `<li data-index="${index}">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ${time}</li>`,