Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Improve CMake build system configuration #5

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

burgholzer
Copy link
Contributor

Hey 👋🏼

while working on the integration of this library into our MQT QECC project I couldn't help but notice that this project could use a little bit of an update in its CMake configuration.
Consider this PR such an effort.
I tried to keep the individual changes isolated so it should be pretty straight-forward to follow the individual commits.
Let me know if anything is unclear or whether you'd prefer to do certain things differently.

The biggest user-facing changes:

  • no more warning during the CMake configure about FetchContent
  • no need to configure and build tests or the main executable if the library is just used as a submodule
  • less likely to result in naming conflicts (main as project and executable)

@lucasberent lucasberent merged commit cb85ee8 into quantumgizmos:main Aug 7, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants