-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(cosmo): harmonise value box colour (opacity) #10029
base: main
Are you sure you want to change the base?
style(cosmo): harmonise value box colour (opacity) #10029
Conversation
@dragonstyle if you happen pass around ? Any reason to have set transparency ? My feeling tells me it may be on purpose for default styling choice. |
|
This PR was not necessarily for 1.5. The changes should only affect value box for the cosmo theme. If not then that would mean there is something very wrong with the structure and the naming inside this SCSS file. |
Most instructive will be to look at these variations in an actual dashboard. What Charles and I found was that more saturated colors tended to take up too much "weight" visually visa-vi the rest of the dashboard, making them feel visually top-heavy. I don't doubt we could come up with improvements, but you need to look at the variations in context to really know. |
A real life example of a dashboard with/without opacity: Screen.Recording.2024-06-18.at.18.11.09.mov(I don't have yet "darken" examples) |
This pull request harmonises the value box opacity in the Cosmo style. The
valuebox-bg-info
andvaluebox-bg-danger
colours have been adjusted to have consistent opacity, i.e., no opacity as the other value box background.Few typos fixed in the changelog.