fix: wrong object used in EJS to get logo-alt for sidebar #10254
+37
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscheid
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Looks good! I have a couple of comments below:
- we want a regression test here to ensure future changes catch our expectation for
sidebar.logo-alt - I think we want to be conservative about newline changes in the ejs templates, and your commit added a newline at the end of a file that didn't have one
After those changes we should be good to merge!
mcanouil
commented
Jul 9, 2024
|
Thanks for bringing this back! The changelog entry needs to be added to 1.7, not 1.6. |
|
Indeed, now that 1.6 is out^^ |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10251
This pull request fixes the issue where the
logo-alttext was not being displayed in the sidebar. The problem was caused by an incorrect reference to thenavbar['logo-alt']variable in the EJS template for the website. The fix updates the template to use the correct object referencesidebar['logo-alt']for the alt text of the logo.