feat: view form validation errors #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbritz
force-pushed
the
feat/view-form-validation-errors
branch
7 times, most recently
from
e8c28df to
7b44e80
Compare
janbritz
force-pushed
the
feat/view-form-validation-errors
branch
from
6302780 to
df54a19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152. Abhängig von #154.
Falls es Fehlermeldungen gibt, die keinem bestimmten Element zugeordnet werden können, werden sie unter dem 'Question name'-Element angezeigt.
Am saubersten wäre es, im Server einen
/validate-options-form-Enpoint zu erstellen, welcher nur die Options Form validiert und bei einem Erfolg den Statuscode 200 zurückgibt. Wie seht ihr das?PS:
Ich wollte die Fehlerbehandlung direkt beim Abspeichern der Frage bzw. beim Aufruf von
save_question_optionsvollziehen, da dadurch nur ein Request zum Server gemacht werden muss. Das war in einer früheren Moodle Version auch möglich, jetzt aber nicht mehr:(aus question/type/questiontypebase.php)