Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for read deadlines on the proxied connection #21

Merged
merged 2 commits into from
May 11, 2024

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented May 10, 2024

Now this was unpleasant code to write, and I'm not 100% sure it's correct.

We need to implement the deadline functions since quic-go calls them from the quic.Transport.

Write deadlines are tracked in #22.

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 69.68%. Comparing base (ed09a8a) to head (3d20d8b).

Files Patch % Lines
conn.go 90.62% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   66.22%   69.68%   +3.46%     
==========================================
  Files           3        3              
  Lines         225      254      +29     
==========================================
+ Hits          149      177      +28     
  Misses         52       52              
- Partials       24       25       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann merged commit 40c6a2b into master May 11, 2024
17 checks passed
@marten-seemann marten-seemann deleted the read-deadlines branch May 11, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant