make SetWriteDeadline a no-op on the proxied conn #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
==========================================
- Coverage 70.49% 70.22% -0.27%
==========================================
Files 3 3
Lines 261 262 +1
==========================================
Hits 184 184
- Misses 52 53 +1
Partials 25 25 ☔ View full report in Codecov by Sentry. |
marten-seemann
force-pushed
the
conn-write-deadline-noop
branch
2 times, most recently
from
31e8195 to
02536b6
Compare
marten-seemann
force-pushed
the
conn-write-deadline-noop
branch
from
02536b6 to
760a04f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #22 for the tracking issue for the actual implementation of write deadlines.