fix: done handlePaylod

will now start tests
quickube · Jun 18, 2024 · 7261c26 · 7261c26
1 parent 921472a
commit 7261c26
Show file tree

Hide file tree

Showing 2 changed files with 95 additions and 80 deletions.
diff --git a/pkg/git_provider/gitlab.go b/pkg/git_provider/gitlab.go
@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"log"
 	"net/http"
+	"strings"
 
 	"github.com/quickube/piper/pkg/conf"
 	"github.com/quickube/piper/pkg/utils"
@@ -243,86 +244,62 @@ func (c *GitlabClientImpl) UnsetWebhook(ctx *context.Context, hook *HookWithStat
 }
 
 func (c *GitlabClientImpl) HandlePayload(ctx *context.Context, request *http.Request, secret []byte) (*WebhookPayload, error) {
-// 	var webhookPayload *WebhookPayload
-
-// 	payload, err := github.ValidatePayload(request, secret)
-// 	if err != nil {
-// 		return nil, err
-// 	}
-
-// 	event, err := github.ParseWebHook(github.WebHookType(request), payload)
-// 	if err != nil {
-// 		return nil, err
-// 	}
-
-// 	switch e := event.(type) {
-// 	case *github.PingEvent:
-// 		webhookPayload = &WebhookPayload{
-// 			Event:   "ping",
-// 			Repo:    e.GetRepo().GetFullName(),
-// 			HookID:  e.GetHookID(),
-// 			OwnerID: e.GetSender().GetID(),
-// 		}
-// 	case *github.PushEvent:
-// 		webhookPayload = &WebhookPayload{
-// 			Event:     "push",
-// 			Action:    e.GetAction(),
-// 			Repo:      e.GetRepo().GetName(),
-// 			Branch:    strings.TrimPrefix(e.GetRef(), "refs/heads/"),
-// 			Commit:    e.GetHeadCommit().GetID(),
-// 			User:      e.GetSender().GetLogin(),
-// 			UserEmail: e.GetHeadCommit().GetAuthor().GetEmail(),
-// 			OwnerID:   e.GetSender().GetID(),
-// 		}
-// 	case *github.PullRequestEvent:
-// 		webhookPayload = &WebhookPayload{
-// 			Event:            "pull_request",
-// 			Action:           e.GetAction(),
-// 			Repo:             e.GetRepo().GetName(),
-// 			Branch:           e.GetPullRequest().GetHead().GetRef(),
-// 			Commit:           e.GetPullRequest().GetHead().GetSHA(),
-// 			User:             e.GetPullRequest().GetUser().GetLogin(),
-// 			UserEmail:        e.GetSender().GetEmail(), // e.GetPullRequest().GetUser().GetEmail() Not working. GitHub missing email for PR events in payload.
-// 			PullRequestTitle: e.GetPullRequest().GetTitle(),
-// 			PullRequestURL:   e.GetPullRequest().GetHTMLURL(),
-// 			DestBranch:       e.GetPullRequest().GetBase().GetRef(),
-// 			Labels:           c.extractLabelNames(e.GetPullRequest().Labels),
-// 			OwnerID:          e.GetSender().GetID(),
-// 		}
-// 	case *github.CreateEvent:
-// 		webhookPayload = &WebhookPayload{
-// 			Event:     "create",
-// 			Action:    e.GetRefType(), // Possible values are: "repository", "branch", "tag".
-// 			Repo:      e.GetRepo().GetName(),
-// 			Branch:    e.GetRef(),
-// 			Commit:    e.GetRef(),
-// 			User:      e.GetSender().GetLogin(),
-// 			UserEmail: e.GetSender().GetEmail(),
-// 			OwnerID:   e.GetSender().GetID(),
-// 		}
-// 	case *github.ReleaseEvent:
-// 		commitSHA, _err := c.refToSHA(ctx, e.GetRelease().GetName(), e.GetRepo().GetName())
-// 		if _err != nil {
-// 			return webhookPayload, _err
-// 		}
-// 		webhookPayload = &WebhookPayload{
-// 			Event:     "release",
-// 			Action:    e.GetAction(), // "created", "edited", "deleted", or "prereleased".
-// 			Repo:      e.GetRepo().GetName(),
-// 			Branch:    e.GetRelease().GetTagName(),
-// 			Commit:    *commitSHA,
-// 			User:      e.GetSender().GetLogin(),
-// 			UserEmail: e.GetSender().GetEmail(),
-// 			OwnerID:   e.GetSender().GetID(),
-// 		}
-// 	}
-
-// 	if c.cfg.EnforceOrgBelonging && (webhookPayload.OwnerID == 0 || webhookPayload.OwnerID != c.cfg.OrgID) {
-// 		return nil, fmt.Errorf("webhook send from non organizational member")
-// 	}
-// 	return webhookPayload, nil
-panic("implement me")
+	var webhookPayload *WebhookPayload
 
+	payload, err := validatePayload(request, secret)
+	if err != nil {
+		return nil, err
+	}
+
+	event, err := gitlab.ParseWebhook(gitlab.WebhookEventType(request), payload)
+	if err != nil {
+		return nil, err
+	}
+
+
+	switch e := event.(type) {
+	case gitlab.PushEvent:
+		webhookPayload = &WebhookPayload{
+			Event:     "push",
+			Action:    e.EventName,
+			Repo:      e.Project.Name,
+			Branch:    strings.TrimPrefix(e.Ref, "refs/heads/"),
+			Commit:    e.CheckoutSHA,
+			User:      e.UserName,
+			UserEmail: e.UserEmail,
+			OwnerID:   int64(e.UserID),
+		}
+	case gitlab.MergeEvent:
+		webhookPayload = &WebhookPayload{
+			Event:            "pull_request",
+			Action:           e.ObjectAttributes.Action,
+			Repo:             e.Repository.Name,
+			Branch:           e.ObjectAttributes.SourceBranch,
+			Commit:           e.ObjectAttributes.LastCommit.ID,
+			User:             e.User.Name,
+			UserEmail:        e.User.Email,
+			PullRequestTitle: e.ObjectAttributes.Title,
+			PullRequestURL:   e.ObjectAttributes.URL,
+			DestBranch:       e.ObjectAttributes.TargetBranch,
+			Labels:           extractLabelsId(e.Labels),
+			OwnerID:          int64(e.User.ID),
+		}
+	case gitlab.ReleaseEvent:
+		webhookPayload = &WebhookPayload{
+			Event:     "release",
+			Action:    e.Action, // "create" | "update" | "delete"
+			Repo:      e.Project.Name,
+			Branch:    e.Tag,
+			Commit:    e.Commit.ID,
+			User:      e.Commit.Author.Name,
+			UserEmail: e.Commit.Author.Email,
+		}
+	}
+
+	if c.cfg.EnforceOrgBelonging && (webhookPayload.OwnerID == 0 || webhookPayload.OwnerID != c.cfg.OrgID) {
+		return nil, fmt.Errorf("webhook send from non organizational member")
+	}
+	return webhookPayload, nil
 }
 
 func (c *GitlabClientImpl) SetStatus(ctx *context.Context, repo *string, commit *string, linkURL *string, status *string, message *string) error {

diff --git a/pkg/git_provider/gitlab_utils.go b/pkg/git_provider/gitlab_utils.go
@@ -1,7 +1,11 @@
 package git_provider
 
 import (
+	"crypto/hmac"
+	"crypto/sha256"
+	"encoding/hex"
 	"fmt"
+	"io"
 	"log"
 	"net/http"
 	"strings"
@@ -112,4 +116,38 @@ func isProjectWebhookEnabled(c *GitlabClientImpl, repo string) (*gitlab.ProjectH
 	}
 
 	return &emptyHook, false
-}
+}
+
+func extractLabelsId(labels []*gitlab.EventLabel) []string {
+	var returnLabelsList []string
+	for _, label := range labels {
+		returnLabelsList = append(returnLabelsList, fmt.Sprint(label.ID))
+	}
+	return returnLabelsList
+}
+
+func validatePayload(r *http.Request, secret []byte) ([]byte, error){
+	payload, err := io.ReadAll(r.Body)
+	if err != nil {
+		return nil, fmt.Errorf("error reading request body: %v", err)
+	}
+
+	// Get GitLab signature from headers
+	gitlabSignature := r.Header.Get("X-Gitlab-Token")
+	if gitlabSignature == "" {
+		return nil, fmt.Errorf("no GitLab signature found in headers")
+	}
+
+	h := hmac.New(sha256.New, secret)
+	_, err = h.Write(payload)
+	if err != nil {
+		return nil, fmt.Errorf("error computing HMAC: %v", err)
+	}
+	expectedMAC := hex.EncodeToString(h.Sum(nil))
+
+	isEquall := hmac.Equal([]byte(gitlabSignature), []byte(expectedMAC))
+	if !isEquall {
+		return nil, fmt.Errorf("secret not correct")
+	}
+	return payload, nil
+}