fix: event handler listen to ctx.Done

quickube · Jan 9, 2025 · d869b7c · d869b7c
1 parent a6d1a48
commit d869b7c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/cmd/piper/piper.go b/cmd/piper/piper.go
@@ -51,6 +51,6 @@ func main() {
 	// Create context that listens for the interrupt signal from the OS.
 	ctx, stop := signal.NotifyContext(context.Background(), syscall.SIGINT, syscall.SIGTERM)
 	defer stop()
-	event_handler.Start(ctx, stop, cfg, globalClients)
+	event_handler.Start(ctx, cfg, globalClients)
 	server.Start(ctx, stop, cfg, globalClients)
 }
diff --git a/pkg/event_handler/main.go b/pkg/event_handler/main.go
@@ -8,7 +8,7 @@ import (
 	"log"
 )
 
-func Start(ctx context.Context, stop context.CancelFunc, cfg *conf.GlobalConfig, clients *clients.Clients) {
+func Start(ctx context.Context, cfg *conf.GlobalConfig, clients *clients.Clients) {
 	labelSelector := &metav1.LabelSelector{
 		MatchExpressions: []metav1.LabelSelectorRequirement{
 			{Key: "piper.quickube.com/notified",
@@ -43,7 +43,6 @@ func Start(ctx context.Context, stop context.CancelFunc, cfg *conf.GlobalConfig,
 					log.Printf("[event handler] failed to Handle workflow event: %v", err2)
 				}
 			}
-			stop()
 		}
 
 	}()