Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gitlab provider #22

Closed
wants to merge 61 commits into from
Closed

feat: add gitlab provider #22

wants to merge 61 commits into from

Conversation

omri2001
Copy link
Contributor

Pull Request

Description

Add support for GitLab as a provider

@omri2001 omri2001 requested a review from GoshaDo as a code owner June 18, 2024 18:29
GoshaDo
GoshaDo requested changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@GoshaDo GoshaDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that personal token, and group token can we chosen for support for now.

  1. write test
  2. add docs
  3. edit values.yaml, give context for new git provider

pkg/git_provider/gitlab_utils.go Show resolved Hide resolved
pkg/git_provider/gitlab.go Outdated Show resolved Hide resolved
pkg/git_provider/gitlab.go Outdated Show resolved Hide resolved
pkg/git_provider/gitlab.go Show resolved Hide resolved
pkg/git_provider/gitlab.go Outdated Show resolved Hide resolved
pkg/git_provider/gitlab_utils.go Outdated Show resolved Hide resolved
pkg/git_provider/gitlab_utils.go Outdated Show resolved Hide resolved
pkg/git_provider/gitlab_utils.go Outdated Show resolved Hide resolved
pkg/git_provider/gitlab.go Outdated Show resolved Hide resolved
pkg/git_provider/gitlab.go Outdated Show resolved Hide resolved
GoshaDo
GoshaDo requested changes Jul 1, 2024
View reviewed changes
pkg/conf/git_provider.go Outdated Show resolved Hide resolved
@GoshaDo
Copy link
Contributor

GoshaDo commented Nov 10, 2024 •
edited
Loading

add to main.go

gitClient, err := NewGitlabClient(cfg)
if err != nil {
	return nil, err
}
return gitClient, nil

GoshaDo
GoshaDo reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@GoshaDo GoshaDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to enable the following setting for local web hooks in the cluster:

admin > network > outbound > Allow requests to the local network from webhooks and integrations

cmd/piper/piper.go Outdated Show resolved Hide resolved
pkg/git_provider/gitlab.go Outdated Show resolved Hide resolved
@omri2001 omri2001 force-pushed the add-gitlab-provider branch from 0d09c44 to 7142da3 Compare November 21, 2024 13:38
GoshaDo
GoshaDo reviewed Nov 23, 2024
View reviewed changes
Copy link
Contributor

@GoshaDo GoshaDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left some comments

.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
examples/template.values.dev.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e.yaml Show resolved Hide resolved
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
scripts/setup-gitlab.sh Outdated Show resolved Hide resolved
scripts/setup-gitlab.sh Outdated Show resolved Hide resolved
scripts/setup-gitlab.sh Outdated Show resolved Hide resolved
scripts/setup-gitlab.sh Outdated Show resolved Hide resolved
scripts/setup-gitlab.sh Outdated Show resolved Hide resolved
GoshaDo
GoshaDo reviewed Nov 23, 2024
View reviewed changes
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
@omri2001 omri2001 force-pushed the add-gitlab-provider branch from 955313d to 8f57832 Compare December 2, 2024 11:01
omri2001 and others added 21 commits December 2, 2024 15:01
@omri2001
fix: gitlab get scopes added
56346e1
@omri2001
fix: finished newgitlabClient
0e4b733
@omri2001
fix: ListFiles complete
a01a407
@omri2001
fix: get File and getFiles
c53f18b
@omri2001
fix: SetStatus + PinkHook
058756e 
still need to do tests on them, not sure if working
@omri2001
fix: set and del webhook done
05bec39
@omri2001
fix: small change setWebhook
a3e6600
@omri2001
fix: done handlePaylod
5dcb125 
will now start tests
@omri2001
fix: pr review changes and fixed scopes
fbd0096
@omri2001
fix: first test done
97207c8
@omri2001
fix: some pr changes resolving
04c9619
@omri2001
docs: added provider and url to chart
748a633
@omri2001
fix: done utils tests
e7908e2
@omri2001
fix: started gitlab tests
446bb17
@omri2001
fix: added some more tests and fixing bugs
eeaa407
@omri2001
fix: finished tests now runnning qa
48ad3d7
@omri2001
fix: added some docs
b177656
@omri2001
fix: added some validations and docs
650a79f
@omri2001
fix: argo ingress
3ec833a
@omri2001
fix: gitlab init ruby script
fbd8249
@GoshaDo @omri2001
ci: add gitlab local support
453d7dc
@omri2001 omri2001 force-pushed the add-gitlab-provider branch from ab97593 to a01ee2c Compare December 2, 2024 13:08
GoshaDo
GoshaDo requested changes Dec 23, 2024
View reviewed changes
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
docs/configuration/environment_variables.md
@@ -5,57 +5,59 @@ The helm chart populates them using [values.yaml](https://github.com/quickube/pi

### Git

* GIT_PROVIDER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the changes in this file

docs/getting_started/installation.md Outdated
@@ -1,6 +1,6 @@
## Installation

You must deploy Piper to a cluster with a pre-existing Argo Workflows deployment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review this file

pkg/event_handler/github_event_notifier.go
@@ -27,6 +27,15 @@ var workflowTranslationToBitbucketMap = map[string]string{
"Error": "STOPPED",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omri2001 agree, can you do it ?

@ssliman
Copy link
Contributor

ssliman commented Dec 24, 2024

Any idea when this is available? Looking to test this out in our environment

@GoshaDo GoshaDo closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoshaDo GoshaDo GoshaDo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omri2001 @GoshaDo @ssliman