fix: event handler listen to ctx.Done #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omri2001
approved these changes
Jan 11, 2025
GoshaDo
force-pushed
the
event-handler-listen-to-ctx-done
branch
from
f90f747 to
b285804
Compare
GoshaDo
force-pushed
the
event-handler-listen-to-ctx-done
branch
from
b285804 to
399a7e6
Compare
adiludmer
reviewed
Jan 11, 2025
| } | ||
| } | ||
| log.Print("[event handler] stopped work, closing watcher") |
There was a problem hiding this comment.
@GoshaDo can explain how the race condition could happen ?
There was a problem hiding this comment.
If stop() is called, it will cancel the context (ctx). If the context is already canceled before watcher.Stop() completes, there could be race conditions or unexpected behavior.
There was a problem hiding this comment.
ok there are no race condition, but it is a good practice to stop the process if the watcher Chanel closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Possible race condition on watcher.Stop() and stop()
Added listen to closure of watcher channel and stop the program
Before submitting this pull request, please ensure that you have completed the following tasks: