fix linter

testing/test_tenda_everest/conftest.py

@@ -1,14 +1,24 @@
+"""
+Fixtures for testing
+"""
 # import requests
-import testing.test_tenda_everest.mocks as mocks
 from pytest import fixture
+from testing.test_tenda_everest import mocks
 
 
 @fixture
 def requests_module():
+    """
+    fixture for requests test module
+    """
     # return requests
     return mocks
 
+
 @fixture
 def host():
+    """
+    fixture for test host
+    """
     return '9.9.9.9'
     # return 'http://10.173.1.142:8081'

testing/test_tenda_everest/mocks/__init__.py

@@ -1,12 +1,24 @@
+"""
+Mocks for requests python module
+"""
 from tenda_everest import MODULES
 from testing.test_tenda_everest.mocks.expected import expected_info
 
 class MockResponse:
+    """
+    Mock for requests.Response class
+    """
 
     def __init__(self, url):
+        """
+        Init mock response
+        """
         self.modules = self.get_modules(url)
 
     def json(self):
+        """
+        mock request.json function
+        """
         result = {}
         for module in self.modules:
             enum_module = MODULES[module]
@@ -15,20 +27,36 @@ def json(self):
 
         return result
 
+
     def get_modules(self, url):
-        host, params = url.split('?')
-        module, values = params.split('=')
+        """
+        special function for mock
+        """
+        _, params = url.split('?')
+        _, values = params.split('=')
         modules = values.split(',')
         return modules
 
 
 class MockSession:
-
-    def get(self, url, *args, **kwargs):
+    """
+    Mock requests.Session class
+    """
+
+    def get(self, url, *args, **kwargs):  # pylint:disable=unused-argument
+        """
+        mock get request
+        """
         return MockResponse(url)
 
     def post(self, *args, **kwargs):
-        pass
+        """
+        mock post request
+        """
+
 
 def session():
+    """
+    mock request.session function
+    """
     return MockSession()

testing/test_tenda_everest/mocks/expected.py

@@ -1,22 +1,25 @@
+"""
+Expected values for tests
+"""
 from tenda_everest import MODULES
 
-hidden_mac = 'XX:XX:XX:XX:XX:XX'
-hidden_dns = 'XX.XX.XXX.XXX'
-hidden_key = '********'
-hidden_user = 'user'
-hidden_ssid = 'SSID'
+HIDDEN_MAC = 'XX:XX:XX:XX:XX:XX'
+HIDDEN_DNS = 'XX.XX.XXX.XXX'
+HIDDEN_KEY = '********'
+HIDDEN_USER = 'user'
+HIDDEN_SSID = 'SSID'
 
 expected_systemInfo = {
     'systemInfo': {
         'lanIP': '192.168.0.1',
         'lanMask': '255.255.255.0',
-        'macHost': hidden_mac,
+        'macHost': HIDDEN_MAC,
         'softVersion': 'V02.03.01.125',
-        'statusWanDns1': hidden_dns,
+        'statusWanDns1': HIDDEN_DNS,
         'statusWanDns2': '1.1.1.1',
         'statusWanGaterway': '10.173.255.1',
         'statusWanIP': '10.173.1.142',
-        'statusWanMAC': hidden_mac,
+        'statusWanMAC': HIDDEN_MAC,
         'statusWanMask': '255.255.255.254',
         'wanConnectTime': '66039',
         'wanType': 'pppoe'
@@ -25,13 +28,13 @@
 
 expected_wanBasicCfg = {
     'wanBasicCfg': {
-         'wanDns1': hidden_dns,
+         'wanDns1': HIDDEN_DNS,
          'wanDns2': '1.1.1.1',
          'wanGateway': '10.173.255.1',
          'wanIP': '10.173.1.142',
          'wanMask': '255.255.255.254',
-         'wanPPPoEPwd': hidden_key,
-         'wanPPPoEUser': hidden_user,
+         'wanPPPoEPwd': HIDDEN_KEY,
+         'wanPPPoEUser': HIDDEN_USER,
          'wanType': 'pppoe'
     }
 }
@@ -46,10 +49,10 @@
         'wifiHideSSID_5G': 'false',
         'wifiNoPwd': 'false',
         'wifiNoPwd_5G': 'false',
-        'wifiPwd': hidden_key,
-        'wifiPwd_5G': hidden_key,
-        'wifiSSID': hidden_ssid,
-        'wifiSSID_5G': hidden_ssid,
+        'wifiPwd': HIDDEN_KEY,
+        'wifiPwd_5G': HIDDEN_KEY,
+        'wifiSSID': HIDDEN_SSID,
+        'wifiSSID_5G': HIDDEN_SSID,
         'wifiSecurityMode': 'WPAWPA2/AES',
         'wifiSecurityMode_5G': 'WPAWPA2/AES',
         'wifiTotalEn': 'true'