-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text based Circuit Rendering Module #244
Conversation
There is one thing that I forgot last time, the public API should be added to the apidoc https://github.com/qutip/qutip-qip/tree/master/doc/source/apidoc, when you add doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a first quick review. A more detailed one will follow.
You can also add the test for matplotlib here, should be fine. There should also be one test for the circuit.draw() interface, making sure that the API is working properly.
The tex renderer should also be renamed to match the convention.
@BoxiLi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the interface of circuit.draw
looks good.
Sorry for the delay and thank you very much for the fix @gadhvirushiraj ! It looks all good. Merge. Lets see how the tutorials run! |
TextRenderer + BaseRenderer + Tests + Documentation
GSOC'24 Project - QuTiP: Enhanced Quantum Circuit Diagrams | Phase#2 PR
Major Task Outline
TextRenderer ✅
Tests ✅
BaseRenderer ✅
Documentation ✅