Support a dict + non-dict pages mix within a column chunk #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll also rename dict-step, because it is not always a dictionary.
gaborcsardi
force-pushed
the
fix/mixed-dict-plain
branch
from
602fe86 to
9130c45
Compare
So it actually works.
Still needs testing, plus working around an rchk issue.
Plus also simplify logic.
|
Tests:
|
Also test mixed dict + non-dict pages.
In mixed dict + non-dict column chunks.
`as.POSIXct()` behaves pretty interestingly... Trick is from parsedate.
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #110.
convert_column_to_r_dictsconvert_column_to_r_dicts_naconvert_column_to_r_int64_dict_nomissconvert_column_to_r_int64_dict_missconvert_column_to_r_float_dict_nomissconvert_column_to_r_float_dict_missconvert_column_to_r_int96_dict_nomissconvert_column_to_r_int96_dict_missconvert_column_to_r_ba_string_dict_nomissconvert_column_to_r_ba_decimal_dict_nomissconvert_column_to_r_ba_raw_dict_nomissconvert_column_to_r_ba_uuid_dict_nomissconvert_column_to_r_ba_float16_dict_nomissconvert_column_to_r_int32_decimal_dict_nomissconvert_column_to_r_int64_decimal_dict_nomiss