Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plugin compatible with 3.13 #44

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

gomoripeti
Copy link

Adjust to changes in rabbit_exchange_type behaviour

I only modified broker_version_requirements in the Makefile as the bazel files already seem to be updated.

Adjust to changes in rabbit_exchange_type behaviour
@gomoripeti
Copy link
Author

CI tests fail with a bazel error

Error computing the main repository mapping: in module dependency chain <root> -> rabbitmq-server@_ -> rabbitmq_osiris@1.8.1: module not found in registries: rabbitmq_osiris@1.8.1

I would need help to understand and address it

@michaelklishin
Copy link
Member

@gomoripeti this change should help rabbitmq/rabbitmq-delayed-message-exchange#251.

recent versions of osiris are available from this registry
@gomoripeti
Copy link
Author

great, thanks for the pointer

@gomoripeti
Copy link
Author

looking at valid dialyzer/test failures

@gomoripeti
Copy link
Author

finally had the time to fix the test failures. this is ready to be reviewed now.

@gomoripeti
Copy link
Author

I know this plugin is not really relevant for the RabbitMQ Core Team. Is there anything more I can do to help merging the necessary changes to release a version that supports RabbitMQ 3.13.x?

@chevett
Copy link

chevett commented Jan 16, 2025

Hi all, thanks for this work. I would greatly appreciate merging this. It's blocking my ability to upgrade rabbit. 🙏

@michaelklishin michaelklishin merged commit 535ed49 into rabbitmq:main Jan 16, 2025
4 checks passed
@michaelklishin
Copy link
Member

Now the same thing has to be done for 4.0.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants