Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the ReliableProducer during the broker restart #268

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

Gsantomaggio
Copy link
Member

  • add random sleep during the producer restart
  • check the stream status during the restart
  • add tests for the reliable producer

* add random sleep during the producer restart
* check the stream status during the restart
* add tests for the reliable producer

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio Gsantomaggio changed the title Closes https://github.com/rabbitmq/rabbitmq-stream-go-client/issues/265 Improve the ReliableProducer during the broker restart Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 11.76471% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 78.30%. Comparing base (3db652a) to head (9df2d7f).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/ha/ha_publisher.go 0.00% 27 Missing ⚠️
pkg/stream/environment.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   80.01%   78.30%   -1.72%     
==========================================
  Files          18       19       +1     
  Lines        2677     2793     +116     
==========================================
+ Hits         2142     2187      +45     
- Misses        384      447      +63     
- Partials      151      159       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gsantomaggio Gsantomaggio added this to the 1.4 milestone Feb 27, 2024
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio Gsantomaggio merged commit a503d8a into main Feb 27, 2024
7 checks passed
@Gsantomaggio Gsantomaggio deleted the restart_producer branch February 27, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant