Merge pull request #357 from kristopolous/334-tiling-unsplit-fix

A cheap fix to prevent the crash described in #334 from happening
raboof · Mar 21, 2023 · a593e44 · a593e44
2 parents aa7f8cb + e170824
commit a593e44
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/mod_tiling/ops.c b/mod_tiling/ops.c
@@ -147,13 +147,20 @@ bool mod_tiling_untile(WTiling *tiling)
 
         reg2=group_do_attach(grp, &param, &data);
 
+        // See #334: tiling->unsplit from the context menu crashes notion
+        if(tiling->managed_list == NULL) {
+            break;
+        }
+
         if(reg2==NULL)
             warn(TR("Unable to move a region from tiling to group."));
     }
 
     tiling->batchop=FALSE;
 
-    region_dispose((WRegion*)tiling);
+    if(tiling->managed_list != NULL) {
+        region_dispose((WRegion*)tiling);
+    }
 
     return TRUE;
 }