Merge pull request #148 from rackspace/issue/146-expiring-value-cache…

…-fix Issue #146 Avoid uncaught exception when handling failure case in expiring-value
rackspace · Dec 3, 2024 · 4ad7777 · 4ad7777
2 parents b39cc70 + 8c5d314
commit 4ad7777
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/expiring-value/lib/expiring-value.ts b/expiring-value/lib/expiring-value.ts
@@ -35,8 +35,8 @@ export class ExpiringValue<T> {
             if (this.options.cacheError) {
                 this.extendExpiration();
             } else {
-                // Update expiration, only upon success
-                this.value.then(() => this.extendExpiration());
+                // Update expiration, only upon success; no-op on error here
+                this.value.then(() => this.extendExpiration()).catch(() => undefined);
             }
         }
 

diff --git a/expiring-value/package.json b/expiring-value/package.json
@@ -10,7 +10,7 @@
   ],
   "scripts": {
     "build": "tsc && npm link && cp dist/expiring-value.d.ts ../docs/types/",
-    "test": "NODE_OPTIONS=--unhandled-rejections=none jest",
+    "test": "jest",
     "test:watch": "jest --watch",
     "clean:publish": "rm -r dist; npm run build && npm publish --access public"
   },