New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: `trim` now requires both arguments #351

Draft

aleclarson wants to merge 1 commit into radashi-org:next from aleclarson:refactor/require-trim-argument

+6 −6

Member

aleclarson commented Feb 4, 2025

Summary

You must provide the “characters to trim” when calling trim.

Related issue, if any:

https://github.com/orgs/radashi-org/discussions/68

For any code change,

Related documentation has been updated, if needed
Related tests have been added or updated, if needed
Related benchmarks have been added or updated, if needed
Release notes in next-minor.md or next-major.md have been added, if needed

Does this PR introduce a breaking change?

Yes


          feat!: trim now requires both arguments

26f1260

aleclarson added this to the v13.0.0 milestone

aleclarson added the BREAKING CHANGE label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BREAKING CHANGE