Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove default size from cluster #352

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

aleclarson
Copy link
Member

@aleclarson aleclarson commented Feb 4, 2025

Summary

This PR removes the default size from the cluster function.

Related issue, if any:

https://github.com/orgs/radashi-org/discussions/91

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed
  • Related benchmarks have been added or updated, if needed
  • Release notes in next-minor.md or next-major.md have been added, if needed

Does this PR introduce a breaking change?

Yes

The size parameter is now required when calling the cluster function. Existing applications will need to provide a size argument when calling the function.

Bundle impact

Status File Size 1 Difference
M src/array/cluster.ts 107 -2 (-2%)

Footnotes

  1. Function size includes the import dependencies of the function.

@radashi-bot
Copy link

Benchmark Results

Name Current Baseline Change
cluster ▶︎ with cluster size of 2 2,949,083.72 ops/sec ±0.73% 3,159,101.05 ops/sec ±0.44% 🔗 🐢 -6.65%
cluster ▶︎ specified cluster size of 3 2,960,403.4 ops/sec ±0.74% 3,164,951.73 ops/sec ±0.88% 🔗 🐢 -6.46%

Performance regressions of 30% or more should be investigated, unless they were anticipated. Smaller regressions may be due to normal variability, as we don't use dedicated CI infrastructure.

@aleclarson aleclarson added this to the v13.0.0 milestone Feb 4, 2025
@aleclarson aleclarson added the BREAKING CHANGE Not backwards compatible label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE Not backwards compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants