Add new keys for factor source slide ups #578
Conversation
| "factorSourceActions_createKey_title": "Creating Key", | ||
| "factorSourceActions_device_messageSignature": "Authenticate to your phone to sign.", | ||
| "factorSourceActions_device_message": "Authenticate to your phone to complete using your phone's signing key.", | ||
| "factorSourceActions_device_signMessage": "Use your phone’s biometrics or PIN to sign", |
There was a problem hiding this comment.
is the factorSourceActions_device_messageSignature still required? Seems confusing to have messageSignature & signMessage
There was a problem hiding this comment.
I wanted to delete the keys, but we had discussed to not remove keys in the past. Are you ok to remove the old ones?
There was a problem hiding this comment.
given that we already need to update code after renaming _passphrase into offDeviceMnemonic, I believe it is a good time to delete them now
There was a problem hiding this comment.
Also
factorSourceActions_ledger_messageSignaturefactorSourceActions_ledger_messageDeriveAccounts
will not be supported. Should we delete?
There was a problem hiding this comment.
If we delete, the still not removed UIs will not compile.
There was a problem hiding this comment.
it is fine, I can make a quick update on main to just use the new Strings (together with the other mentioned updates) and then on future PR update the entire UI
| "transactionReview_deletingAccount_message": "Deleting Account. Permanently removing access and preventing future deposits.", | ||
| "transactionReview_signingTransactionFailure_title": "Cannot Sign Transaction", | ||
| "transactionReview_signingTransactionFailure_message": "You’ve skipped too many factors and cannot sign the transaction. You can restart the signing process, or cancel it.", | ||
| "transactionReview_signingTransactionFailure_restart": "Restart Signing", | ||
| "transactionReview_signingTransactionFailure_cancel": "Cancel Transaction" |
There was a problem hiding this comment.
Keys for
transactionReviewandfactorSourceActions