Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix transaction stream performance edge case. #832

Merged
merged 3 commits into from
Mar 5, 2025
+62 −51
Merged

fix transaction stream performance edge case. #832

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24e365a
fix transaction stream performance edge case.
PawelPawelec-RDX Mar 5, 2025
69089d0
apply state version boundary.
PawelPawelec-RDX Mar 5, 2025
5aebd55
another micro optimization to remove extra join if possible.
PawelPawelec-RDX Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 62 additions & 51 deletions src/RadixDlt.NetworkGateway.PostgresIntegration/Services/TransactionQuerier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,17 +158,7 @@ public async Task<TransactionPageWithoutTotal> GetTransactionStream(TransactionS
? request.Cursor?.StateVersionBoundary ?? request.FromStateVersion
: request.FromStateVersion;

var baseQuery = _dbContext
.LedgerTransactions
.Where(lt => lt.StateVersion <= upperStateVersion && lt.StateVersion >= (lowerStateVersion ?? lt.StateVersion));

var searchQuery = request.SearchCriteria.Status switch
{
LedgerTransactionStatusFilter.All => baseQuery.Select(lt => lt.StateVersion),
LedgerTransactionStatusFilter.Success => baseQuery.Where(x => x.ReceiptStatus == LedgerTransactionStatus.Succeeded).Select(lt => lt.StateVersion),
LedgerTransactionStatusFilter.Failure => baseQuery.Where(x => x.ReceiptStatus == LedgerTransactionStatus.Failed).Select(lt => lt.StateVersion),
_ => throw new NotSupportedException($"Not supported status: {request.SearchCriteria.Status}"),
};
IQueryable<long>? searchQuery = null;

var userKindFilterImplicitlyApplied = false;

Expand Down Expand Up @@ -196,12 +186,7 @@ public async Task<TransactionPageWithoutTotal> GetTransactionStream(TransactionS
return TransactionPageWithoutTotal.Empty;
}

searchQuery = searchQuery
.Join(
_dbContext.LedgerTransactionMarkers,
stateVersion => stateVersion,
ledgerTransactionMarker => ledgerTransactionMarker.StateVersion,
(stateVersion, ledgerTransactionMarker) => ledgerTransactionMarker)
searchQuery = PrepareForNextFilter(searchQuery)
.OfType<ResourceBalanceChangeTransactionMarker>()
.Where(maltm => maltm.EntityId == entityId)
.Where(maltm => maltm.StateVersion <= upperStateVersion && maltm.StateVersion >= (lowerStateVersion ?? maltm.StateVersion))
Expand Down Expand Up @@ -263,8 +248,7 @@ public async Task<TransactionPageWithoutTotal> GetTransactionStream(TransactionS
return TransactionPageWithoutTotal.Empty;
}

searchQuery = searchQuery
.Join(_dbContext.LedgerTransactionMarkers, sv => sv, ltm => ltm.StateVersion, (sv, ltm) => ltm)
searchQuery = PrepareForNextFilter(searchQuery)
.OfType<AffectedGlobalEntityTransactionMarker>()
.Where(agetm => agetm.EntityId == entityId)
.Where(agetm => agetm.StateVersion <= upperStateVersion && agetm.StateVersion >= (lowerStateVersion ?? agetm.StateVersion))
Expand All @@ -281,8 +265,7 @@ public async Task<TransactionPageWithoutTotal> GetTransactionStream(TransactionS
return TransactionPageWithoutTotal.Empty;
}

searchQuery = searchQuery
.Join(_dbContext.LedgerTransactionMarkers, sv => sv, ltm => ltm.StateVersion, (sv, ltm) => ltm)
searchQuery = PrepareForNextFilter(searchQuery)
.OfType<EventGlobalEmitterTransactionMarker>()
.Where(agetm => agetm.EntityId == entityId)
.Where(agetm => agetm.StateVersion <= upperStateVersion && agetm.StateVersion >= (lowerStateVersion ?? agetm.StateVersion))
Expand Down Expand Up @@ -326,8 +309,7 @@ public async Task<TransactionPageWithoutTotal> GetTransactionStream(TransactionS
eventResourceEntityId = id;
}

searchQuery = searchQuery
.Join(_dbContext.LedgerTransactionMarkers, sv => sv, ltm => ltm.StateVersion, (sv, ltm) => ltm)
searchQuery = PrepareForNextFilter(searchQuery)
.OfType<EventLedgerTransactionMarker>()
.Where(eltm => eltm.EventType == eventType && eltm.EntityId == (eventEmitterEntityId ?? eltm.EntityId) && eltm.ResourceEntityId == (eventResourceEntityId ?? eltm.ResourceEntityId))
.Where(eltm => eltm.StateVersion <= upperStateVersion && eltm.StateVersion >= (lowerStateVersion ?? eltm.StateVersion))
Expand All @@ -352,8 +334,7 @@ public async Task<TransactionPageWithoutTotal> GetTransactionStream(TransactionS
_ => throw new UnreachableException($"Didn't expect {request.SearchCriteria.ManifestClassFilter.Class} value"),
};

searchQuery = searchQuery
.Join(_dbContext.LedgerTransactionMarkers, sv => sv, ltm => ltm.StateVersion, (sv, ltm) => ltm)
searchQuery = PrepareForNextFilter(searchQuery)
.OfType<ManifestClassMarker>()
.Where(ttm => ttm.ManifestClass == manifestClass)
.Where(ttm => (request.SearchCriteria.ManifestClassFilter.MatchOnlyMostSpecificType && ttm.IsMostSpecific) || !request.SearchCriteria.ManifestClassFilter.MatchOnlyMostSpecificType)
Expand Down Expand Up @@ -392,6 +373,10 @@ public async Task<TransactionPageWithoutTotal> GetTransactionStream(TransactionS
.Where(maltm => maltm.StateVersion <= upperStateVersion && maltm.StateVersion >= (lowerStateVersion ?? maltm.StateVersion))
.Select(y => y.StateVersion);

searchQuery ??= _dbContext.LedgerTransactionMarkers
.Where(ltm => ltm.StateVersion <= upperStateVersion && ltm.StateVersion >= (lowerStateVersion ?? ltm.StateVersion))
.Select(x => x.StateVersion);

searchQuery = searchQuery.Where(x => withManifestOwnerCall.All(y => y != x));
}
}
Expand All @@ -406,31 +391,46 @@ public async Task<TransactionPageWithoutTotal> GetTransactionStream(TransactionS
}
else if (request.SearchCriteria.Kind == LedgerTransactionKindFilter.UserOnly)
{
searchQuery = searchQuery
.Join(_dbContext.LedgerTransactionMarkers, sv => sv, ltm => ltm.StateVersion, (sv, ltm) => ltm)
searchQuery = PrepareForNextFilter(searchQuery)
.OfType<TransactionTypeLedgerTransactionMarker>()
.Where(oltm => oltm.TransactionType == LedgerTransactionMarkerTransactionType.User)
.Where(oltm => oltm.StateVersion <= upperStateVersion && oltm.StateVersion >= (lowerStateVersion ?? oltm.StateVersion))
.Select(oltm => oltm.StateVersion);
}
else if (request.SearchCriteria.Kind == LedgerTransactionKindFilter.EpochChangeOnly)
{
searchQuery = searchQuery
.Join(_dbContext.LedgerTransactionMarkers, sv => sv, ltm => ltm.StateVersion, (sv, ltm) => ltm)
searchQuery = PrepareForNextFilter(searchQuery)
.OfType<EpochChangeLedgerTransactionMarker>()
.Where(ecltm => ecltm.EpochChange)
.Where(ecltm => ecltm.StateVersion <= upperStateVersion && ecltm.StateVersion >= (lowerStateVersion ?? ecltm.StateVersion))
.Select(ecltm => ecltm.StateVersion);
}

if (request.AscendingOrder)
if (searchQuery == null || request.SearchCriteria.Status != LedgerTransactionStatusFilter.All)
{
searchQuery = searchQuery.OrderBy(sv => sv);
var query = searchQuery == null ?
_dbContext.LedgerTransactions.Where(lt => lt.StateVersion <= upperStateVersion && lt.StateVersion >= (lowerStateVersion ?? lt.StateVersion))
: searchQuery.Join(
_dbContext.LedgerTransactions,
stateVersion => stateVersion,
ledgerTransactionMarker => ledgerTransactionMarker.StateVersion,
(stateVersion, ledgerTransactionMarker) => ledgerTransactionMarker)
.Where(lt => lt.StateVersion <= upperStateVersion && lt.StateVersion >= (lowerStateVersion ?? lt.StateVersion));

searchQuery = request.SearchCriteria.Status switch
{
LedgerTransactionStatusFilter.All => query.Select(lt => lt.StateVersion),
LedgerTransactionStatusFilter.Success => query.Where(x => x.ReceiptStatus == LedgerTransactionStatus.Succeeded).Select(lt => lt.StateVersion),
LedgerTransactionStatusFilter.Failure => query.Where(x => x.ReceiptStatus == LedgerTransactionStatus.Failed).Select(lt => lt.StateVersion),
_ => throw new NotSupportedException($"Not supported status: {request.SearchCriteria.Status}"),
};
}
else

searchQuery = request.AscendingOrder switch
{
searchQuery = searchQuery.OrderByDescending(sv => sv);
}
true => searchQuery.OrderBy(sv => sv),
_ => searchQuery.OrderByDescending(sv => sv),
};

var stateVersions = await searchQuery
.TagWith(ForceDistinctInterceptor.Apply)
Expand All @@ -446,19 +446,28 @@ public async Task<TransactionPageWithoutTotal> GetTransactionStream(TransactionS

return new TransactionPageWithoutTotal(nextCursor, transactions);

IQueryable<long> ApplyLedgerTransactionMarkerOperationTypeFilter(long entityId, LedgerTransactionMarkerOperationType operationType, IQueryable<long> query)
IQueryable<long> ApplyLedgerTransactionMarkerOperationTypeFilter(long entityId, LedgerTransactionMarkerOperationType operationType, IQueryable<long>? query)
{
return query
.Join(
_dbContext.LedgerTransactionMarkers,
stateVersion => stateVersion,
ledgerTransactionMarker => ledgerTransactionMarker.StateVersion,
(stateVersion, ledgerTransactionMarker) => ledgerTransactionMarker)
return PrepareForNextFilter(query)
.OfType<ManifestAddressLedgerTransactionMarker>()
.Where(maltm => maltm.OperationType == operationType && maltm.EntityId == entityId)
.Where(maltm => maltm.StateVersion <= upperStateVersion && maltm.StateVersion >= (lowerStateVersion ?? maltm.StateVersion))
.Select(maltm => maltm.StateVersion);
}

IQueryable<LedgerTransactionMarker> PrepareForNextFilter(IQueryable<long>? baseQuery)
{
if (baseQuery == null)
{
return _dbContext.LedgerTransactionMarkers;
}

return baseQuery.Join(
_dbContext.LedgerTransactionMarkers,
stateVersion => stateVersion,
ledgerTransactionMarker => ledgerTransactionMarker.StateVersion,
(stateVersion, ledgerTransactionMarker) => ledgerTransactionMarker);
}
}

public async Task<GatewayModel.CommittedTransactionInfo?> LookupCommittedTransaction(
Expand Down Expand Up @@ -705,11 +714,12 @@ private async Task<ICollection<PendingTransactionSummary>> LookupPendingTransact

var detailedEventEmitter = new GatewayModel.PackageFunctionEventEmitter(new GatewayModel.FunctionEmitter(functionEventEmitterIdentifier.BlueprintName));

detailedEvents.Add(new GatewayModel.DetailedEventsItem(
detailedIdentifier,
payloadTypeDefinition,
detailedEventEmitter,
payload));
detailedEvents.Add(
new GatewayModel.DetailedEventsItem(
detailedIdentifier,
payloadTypeDefinition,
detailedEventEmitter,
payload));
}
else if (parsedEmitter is CoreModel.MethodEventEmitterIdentifier methodEventEmitterIdentifier)
{
Expand All @@ -728,11 +738,12 @@ private async Task<ICollection<PendingTransactionSummary>> LookupPendingTransact
outerEmitter: eventDetails.OuterObjectAddress,
globalEmitter: eventDetails.GlobalAncestorAddress ?? methodEventEmitterIdentifier.Entity.EntityAddress);

detailedEvents.Add(new GatewayModel.DetailedEventsItem(
detailedIdentifier,
payloadTypeDefinition,
detailedEventEmitter,
payload));
detailedEvents.Add(
new GatewayModel.DetailedEventsItem(
detailedIdentifier,
payloadTypeDefinition,
detailedEventEmitter,
payload));
}
else
{
Expand Down