Fix/minor cleanups for ledger submission 1 (#25)

* Fix tx hash text; Fix show hash for known tx type
* Fix compilation error due to compiler internal error (1.72.0-nightly)
* Fix CI pipeline

.github/workflows/ci.yml

@@ -30,7 +30,7 @@ jobs:
       - name: Install toolchains
         uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly
+          toolchain: nightly-2023-05-28
           override: true
           components: rust-src, clippy
       - uses: actions/checkout@v2
@@ -45,7 +45,7 @@ jobs:
       - name: Install toolchains
         uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly
+          toolchain: nightly-2023-05-28
           override: true
           components: rust-src, rustfmt
       - uses: actions/checkout@v2
@@ -71,7 +71,7 @@ jobs:
       - name: Install toolchains
         uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly
+          toolchain: nightly-2023-05-28
           override: true
           components: rust-src
       - uses: actions/checkout@v2

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "babylon-ledger-app"
-version = "0.3.1"
+version = "0.3.2"
 authors = ["siy"]
 edition = "2021"
 description = "Radix Babylon"

app-builder/Dockerfile

@@ -27,9 +27,9 @@ RUN ls -la /root/
 
 ENV PATH="/root/.cargo/bin:${PATH}"
 ENV LEDGER_TARGETS=/app/target-config
-RUN /root/.cargo/bin/rustup update
+RUN /root/.cargo/bin/rustup toolchain remove stable
+RUN /root/.cargo/bin/rustup default nightly-2023-05-28
 RUN /root/.cargo/bin/rustup target install thumbv7m-none-eabi
-RUN /root/.cargo/bin/rustup default nightly
 RUN /root/.cargo/bin/rustup component add rust-src
 RUN /root/.cargo/bin/cargo install --git https://github.com/radixdlt/cargo-ledger.git
 RUN pip3 install --upgrade protobuf setuptools ecdsa && pip3 install ledgerwallet && pip3 install protobuf==3.20.3

src/sign/tx_state.rs

@@ -79,7 +79,7 @@ impl<T> TxState<T> {
             self.processor.set_show_instructions();
             self.show_digest = match tx_type {
                 SignType::Ed25519 | SignType::Secp256k1 => comm.get_apdu_metadata().p1 == 1,
-                SignType::Ed25519Summary | SignType::Secp256k1Summary => true,
+                SignType::Ed25519Summary | SignType::Secp256k1Summary => false,
                 SignType::AuthEd25519 | SignType::AuthSecp256k1 => false,
             };
             self.show_introductory_screen(tx_type)?;
@@ -219,7 +219,7 @@ impl<T> TxState<T> {
 
     fn show_digest(&mut self, digest: &Digest) {
         if self.show_digest {
-            self.info_message(b"Digest:", &digest.as_hex());
+            self.info_message(b"TX Hash:", &digest.as_hex());
         }
     }
 
@@ -234,6 +234,12 @@ impl<T> TxState<T> {
             SignType::Ed25519Summary | SignType::Secp256k1Summary => {
                 self.show_detected_tx_type(&detected_type);
                 self.show_transaction_fee(&detected_type);
+
+                self.show_digest = match detected_type {
+                    DetectedTxType::Transfer | DetectedTxType::TransferWithFee(..) => false,
+                    DetectedTxType::Other | DetectedTxType::OtherWithFee(..) => true,
+                };
+
                 self.show_digest(digest);
             }
             SignType::AuthEd25519 | SignType::AuthSecp256k1 => {}