Hotfix/1.11.6 #1338
Merged
Hotfix/1.11.6 #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giannis-rdx
approved these changes
Feb 21, 2025
sergiupuhalschi-rdx
approved these changes
Feb 21, 2025
sergiupuhalschi-rdx
approved these changes
Feb 24, 2025
…definition address points to another. This stems from an old bug on VerifyDAppsUseCase were a dApp was always verified when dev mode was enabled. It was later fixed to always verify the network id of that dApp is the same with the current network id.
giannis-rdx
reviewed
Feb 25, 2025
Comment on lines
+171
to
+177
| /** | ||
| * Simple extension on `ProfileNetwork` that filters out dApps with dAppDefinitionAddress | ||
| * on another network. All AuthorizedDApps are supposed to be under the same `ProfileNetwork::networkId` | ||
| * but due to an old bug that was later fixed on `VerifyDAppUseCase`, there seems to be some profiles that | ||
| * have authorized dApps with dApp definition address pointing to another network. A user with | ||
| * **Developer Mode ON** could "verify" any dApp and store it in profile. | ||
| */ |
There was a problem hiding this comment.
good that you added an explanation there, thanks!
sergiupuhalschi-rdx
approved these changes
Feb 26, 2025
# Conflicts: # app/src/main/java/com/babylon/wallet/android/presentation/ui/composables/assets/StakingTab.kt # core/src/main/java/rdx/works/core/sargon/ProfileExtensions.kt
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses three fixes:
Estimatedlabel on NFTs that are classified as predicted in tx analysis, in both non fungible collections and in stake claimsAmount of deposit is unknown